Let user see the full type of type-length limit error by kornelski · Pull Request #76843 · rust-lang/rust

kornelski · 2020-09-17T16:34:51Z

Seeing the full type of the error is sometimes essential to diagnosing the problem, but the type itself is too long to be displayed in the terminal in a useful fashion. This change solves this dilemma by writing the full offending type name to a file, and displays this filename as a note.

note: the full type name been written to '$TEST_BUILD_DIR/issues/issue-22638/issue-22638.long-type.txt'

Closes #76777

rust-highfive · 2020-09-17T16:34:55Z

r? @ecstatic-morse

(rust_highfive has picked a reviewer for you, use r? to override)

ecstatic-morse

Writing a file as part of diagnostics is novel AFAICT, but seems like the right thing to do in this case. One question, will cargo clean remove this?

kornelski · 2020-09-17T22:30:36Z

The path is chosen by an existing function for temp files (it's very handy that rustc already has that), and cargo clean does clean it properly.

ecstatic-morse · 2020-09-17T22:39:44Z

@bors delegate+ rollup

r=me with or without suggestion and with tests passing.

bors · 2020-09-17T22:39:45Z

✌️ @kornelski can now approve this pull request

kornelski · 2020-09-17T23:26:25Z

@bors r+

bors · 2020-09-17T23:26:26Z

📌 Commit 677c6fcfe47471614abc2f6aed0e9e16cbda0790 has been approved by kornelski

bors · 2020-09-18T16:53:37Z

☔ The latest upstream changes (presumably #72412) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

kornelski · 2020-09-20T01:33:06Z

@bors r+

bors · 2020-09-20T01:33:08Z

📌 Commit c5968e8 has been approved by kornelski

ecstatic-morse · 2020-09-20T05:55:17Z

@bors r- r=ecstatic-morse

@kornelski please use the name of the reviewer when delegated to.

bors · 2020-09-20T05:55:19Z

📌 Commit c5968e8 has been approved by ecstatic-morse

…c-morse Let user see the full type of type-length limit error Seeing the full type of the error is sometimes essential to diagnosing the problem, but the type itself is too long to be displayed in the terminal in a useful fashion. This change solves this dilemma by writing the full offending type name to a file, and displays this filename as a note. > note: the full type name been written to '$TEST_BUILD_DIR/issues/issue-22638/issue-22638.long-type.txt' Closes rust-lang#76777

RalfJung · 2020-09-20T10:06:06Z

Failed in #76957 (comment)
@bors r-

kornelski · 2020-09-20T23:45:39Z

build path normalization doesn't cover nll tests. I've added explicit normalization for them.

RalfJung · 2020-09-21T07:16:34Z

@bors r=ecstatic-morse rollup=iffy

bors · 2020-09-21T07:16:35Z

📌 Commit 34d3c7d has been approved by ecstatic-morse

bors · 2020-09-21T08:20:45Z

⌛ Testing commit 34d3c7d with merge 0433fdf...

bors · 2020-09-21T10:26:50Z

☀️ Test successful - checks-actions, checks-azure
Approved by: ecstatic-morse
Pushing 0433fdf to master...

rust-highfive assigned ecstatic-morse Sep 17, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020

kornelski mentioned this pull request Sep 17, 2020

Show more of the overlong type on type-length error #76777

Closed

ecstatic-morse reviewed Sep 17, 2020

View reviewed changes

Comment thread compiler/rustc_mir/src/monomorphize/collector.rs Outdated

kornelski force-pushed the longtypetofile branch from ee35975 to be65c12 Compare September 17, 2020 22:26

ecstatic-morse reviewed Sep 17, 2020

View reviewed changes

Comment thread compiler/rustc_mir/src/monomorphize/collector.rs Outdated

rust-lang deleted a comment from bors Sep 17, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2020

kornelski force-pushed the longtypetofile branch from 677c6fc to c5968e8 Compare September 18, 2020 21:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2020

RalfJung mentioned this pull request Sep 20, 2020

Rollup of 15 pull requests #76957

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2020

Let user see the full type of type-length limit error

34d3c7d

kornelski force-pushed the longtypetofile branch from c5968e8 to 34d3c7d Compare September 20, 2020 23:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 21, 2020

bors merged commit 0433fdf into rust-lang:master Sep 21, 2020

rustbot added this to the 1.48.0 milestone Sep 21, 2020

bors mentioned this pull request Sep 21, 2020

Record tcx.def_span instead of item.span in crate metadata #76898

Merged

kornelski deleted the longtypetofile branch September 21, 2020 19:31

minaminao mentioned this pull request Dec 12, 2020

E0320 error huge type name output #79972

Closed

dtolnay mentioned this pull request Jul 19, 2023

Support --print KIND=PATH command line syntax #113780

Merged

Uh oh!

Conversation

kornelski commented Sep 17, 2020

Uh oh!

rust-highfive commented Sep 17, 2020

Uh oh!

ecstatic-morse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kornelski commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ecstatic-morse commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Sep 17, 2020

Uh oh!

kornelski commented Sep 17, 2020

Uh oh!

bors commented Sep 17, 2020

Uh oh!

bors commented Sep 18, 2020

Uh oh!

kornelski commented Sep 20, 2020

Uh oh!

bors commented Sep 20, 2020

Uh oh!

ecstatic-morse commented Sep 20, 2020

Uh oh!

bors commented Sep 20, 2020

Uh oh!

RalfJung commented Sep 20, 2020

Uh oh!

kornelski commented Sep 20, 2020

Uh oh!

RalfJung commented Sep 21, 2020

Uh oh!

bors commented Sep 21, 2020

Uh oh!

bors commented Sep 21, 2020

Uh oh!

bors commented Sep 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kornelski commented Sep 17, 2020 •

edited

Loading

ecstatic-morse commented Sep 17, 2020 •

edited

Loading