Skip to content

Update hashbrown to 0.8.2#75306

Merged
bors merged 1 commit into
rust-lang:masterfrom
Amanieu:hashbrown8
Aug 9, 2020
Merged

Update hashbrown to 0.8.2#75306
bors merged 1 commit into
rust-lang:masterfrom
Amanieu:hashbrown8

Conversation

@Amanieu

@Amanieu Amanieu commented Aug 8, 2020

Copy link
Copy Markdown
Member

Includes:

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2020
@Amanieu

Amanieu commented Aug 8, 2020

Copy link
Copy Markdown
Member Author

@bors rollup=never

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 8, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 99f0052 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2020
@Amanieu

Amanieu commented Aug 8, 2020

Copy link
Copy Markdown
Member Author

cc @nnethercote

@Mark-Simulacrum

Copy link
Copy Markdown
Member

I figured we could land this and check perf after it lands, by the way - it won't get rolled up already (thanks!) and shouldn't be a regression.

@bors

bors commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 99f0052 with merge aced185...

@bors

bors commented Aug 9, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing aced185 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2020
@bors bors merged commit aced185 into rust-lang:master Aug 9, 2020
@nnethercote

nnethercote commented Aug 9, 2020

Copy link
Copy Markdown
Contributor

Perf results from the landing. A bit weird; lots of improvements but some regressions as well, most in the incr-patched runs. I'm disappointed it's not a clearer and more uniform win, like I saw in my local results.

@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants