Skip to content

Update rustc-guide#66161

Merged
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:fix-rustc-guide
Nov 11, 2019
Merged

Update rustc-guide#66161
bors merged 1 commit into
rust-lang:masterfrom
mark-i-m:fix-rustc-guide

Conversation

@mark-i-m

@mark-i-m mark-i-m commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

r? @ehuss

fix #66144

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2019
@ehuss

ehuss commented Nov 7, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 7, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 7ddb899 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 8, 2019
@Centril

Centril commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

Failed in #66218 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2019
@mark-i-m

mark-i-m commented Nov 8, 2019

Copy link
Copy Markdown
Contributor Author

Oh, I thought we said we didn't want to rollup rustc-guide updates since they frequently break. In this case, the links changed yesterday. I have a PR up to fix them and will update this PR after that.

@mark-i-m

mark-i-m commented Nov 8, 2019

Copy link
Copy Markdown
Contributor Author

@ehuss Updated

@Centril norullup please ❤️ Sorry for the trouble.

@Centril

Centril commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

@bors rollup=never

@ehuss

ehuss commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 8, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 8635482 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2019
@bors

bors commented Nov 10, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8635482 with merge e2fa952...

bors added a commit that referenced this pull request Nov 10, 2019
@bors

bors commented Nov 11, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing e2fa952 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 11, 2019
@bors bors merged commit 8635482 into rust-lang:master Nov 11, 2019
@rust-highfive

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #66161!

Tested on commit e2fa952.
Direct link to PR: #66161

🎉 rustc-guide on linux: test-fail → test-pass (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Nov 11, 2019
Tested on commit rust-lang/rust@e2fa952.
Direct link to PR: <rust-lang/rust#66161>

🎉 rustc-guide on linux: test-fail → test-pass (cc @amanjeev @spastorino @mark-i-m, @rust-lang/infra).
@mark-i-m mark-i-m deleted the fix-rustc-guide branch December 11, 2019 21:35
@JohnTitor JohnTitor mentioned this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken links in rustbook

5 participants