Skip to content

Remove header licenses across the project#57108

Merged
bors merged 2 commits into
rust-lang:masterfrom
Mark-Simulacrum:license-remove
Dec 26, 2018
Merged

Remove header licenses across the project#57108
bors merged 2 commits into
rust-lang:masterfrom
Mark-Simulacrum:license-remove

Conversation

@Mark-Simulacrum

Copy link
Copy Markdown
Member

This pull request removes the header licenses from files across the Rust repository.

I've attempted to check for any remaining headers and removed all of them -- any we've missed can be removed in the future; there's nothing blocking that.

Unfortunately, not all of the changes are as basic as "removing a header" because some of them required test file updates or otherwise. However, I am fairly confident that the changes in this pull request, while wide-sweeping, are unlikely to actually make any tests fail to properly test the code; any non-script based changes were manual and carefully verified.

r? @pietroalbini cc @rust-lang/infra

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2018
@emilyalbini

Copy link
Copy Markdown
Member

@bors r+ p=1000

It would be nice to get a tidy check that looks for the header in the future, but that doesn't need to be included in this PR. Thanks Mark! 🎉

@bors

bors commented Dec 24, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit d147ce5ae307dd04541fa603daeed15ffce27462 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2018
@bors

bors commented Dec 24, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d147ce5ae307dd04541fa603daeed15ffce27462 with merge 9e35dc0e3aee786a3b439828ed40374c8af8259c...

@bors

bors commented Dec 24, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 24, 2018
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@Mark-Simulacrum Mark-Simulacrum force-pushed the license-remove branch 3 times, most recently from b0e4495 to d797cd6 Compare December 25, 2018 01:27
@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors r=pietroalbini

@bors

bors commented Dec 25, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit d797cd6e258ff1b24039992c92d9df03a2e762d6 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 25, 2018
@bors

bors commented Dec 25, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d797cd6e258ff1b24039992c92d9df03a2e762d6 with merge 8b53008d9ee36cfb8ebdb9a1af3377c026bbcd06...

@bors

bors commented Dec 25, 2018

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 25, 2018
@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

Could've sworn I had tested these test failures...

@bors r=pietroalbini

@emilyalbini

Copy link
Copy Markdown
Member

@bors treeclose-

@sanmai-NL

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum What was the motivation for this change? How does it bear on e.g. #25664?

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

No bearing, to my knowledge. The code is still licensed as before (MIT/Apache), just is cleaner by skipping the ~10 lines of boilerplate code in every file.

@sanmai-NL

sanmai-NL commented Dec 31, 2018

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum: I agree about it looking cleaner. But I remember past discussion on GitHub where, if I recall correctly, Mozilla was said to have found the license header at the top of every source file legally necessary.

What do you think about adding SPDX comments to every file instead? See https://spdx.org/sites/cpstandard/files/pages/files/using_spdx_license_list_short_identifiers.pdf . Within a project of mine, this was required.

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

If you'd like to discuss this further, let's do it on internals (this isn't the best place).

However, I believe that the current decision will stand unless there's some firm evidence to do otherwise; see #53654, #53617, and #43498 for the primary discussion.

@SimonSapin

Copy link
Copy Markdown
Contributor

@Mark-Simulacrum, @pietroalbini, was there previous discussion of this change somewhere? Not that I’m opposed to it, but I’m curious of the arguments. Do the reasons these headers were added in the first place no longer hold? Why?

@emilyalbini

Copy link
Copy Markdown
Member

@SimonSapin the discussion was in #43498.

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

See #53654, #53617, and #43498 - the core team discussed this a while back and came to the conclusion that the header is no longer necessary.

BurntSushi added a commit to rust-lang/regex that referenced this pull request Aug 3, 2019
The Rust project determined these were unnecessary a while back[1,2,3]
and we follow suite.

[1] - rust-lang/rust@0565653
[2] - rust-lang/rust#43498
[3] - rust-lang/rust#57108
@ehuss ehuss mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants