Make Share::share final and improve docs by P8L1 · Pull Request #157655 · rust-lang/rust

P8L1 · 2026-06-09T09:15:22Z

Tracking issue: #156756

This follows up on the initial unstable Share trait added in #156828.

The original API used an ordinary default method:

fn share(&self) -> Self {
    Clone::clone(self)
}

Niko pointed out that share should be final, since Share is meant to communicate the semantics of Clone::clone for clone-as-alias types, not provide a second independently-overridable operation.

Share remains unstable under #![feature(share_trait)].

r? @nikomatsakis

nikomatsakis · 2026-06-10T20:04:24Z

bors delegate+

This looks good to me. I had one small suggestion.

Co-authored-by: Niko Matsakis <niko@alum.mit.edu>

P8L1 · 2026-06-12T08:10:23Z

@bors r+

rust-bors · 2026-06-12T08:10:28Z

@P8L1: 🔑 Insufficient privileges: not in review users

P8L1 · 2026-06-12T08:11:26Z

@bors r=nikomatsakis

rust-bors · 2026-06-12T08:13:42Z

@P8L1: 🔑 Insufficient privileges: not in review users

P8L1 · 2026-06-12T08:15:16Z

Lol I dont know what's going wrong here @bors r="nikomatsakis"

rust-bors · 2026-06-12T08:27:52Z

@P8L1: 🔑 Insufficient privileges: not in review users

nikomatsakis · 2026-06-12T12:04:06Z

@bors r+ delegate+

rust-bors · 2026-06-12T12:04:09Z

📌 Commit 25e83a0 has been approved by nikomatsakis

It is now in the queue for this repository.

@nikomatsakis

…omatsakis Make Share::share final and improve docs Tracking issue: rust-lang#156756 This follows up on the initial unstable `Share` trait added in rust-lang#156828. The original API used an ordinary default method: ```rust fn share(&self) -> Self { Clone::clone(self) } ``` Niko pointed out that `share` should be final, since `Share` is meant to communicate the semantics of `Clone::clone` for clone-as-alias types, not provide a second independently-overridable operation. `Share` remains unstable under `#![feature(share_trait)]`. r? @nikomatsakis

@nikomatsakis

…omatsakis Make Share::share final and improve docs Tracking issue: rust-lang#156756 This follows up on the initial unstable `Share` trait added in rust-lang#156828. The original API used an ordinary default method: ```rust fn share(&self) -> Self { Clone::clone(self) } ``` Niko pointed out that `share` should be final, since `Share` is meant to communicate the semantics of `Clone::clone` for clone-as-alias types, not provide a second independently-overridable operation. `Share` remains unstable under `#![feature(share_trait)]`. r? @nikomatsakis

…uwer Rollup of 17 pull requests Successful merges: - #156950 (Staticlib rename internal symbols) - #157322 (test pre-stabilization items on CI) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N)) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))

@nikomatsakis

…omatsakis Make Share::share final and improve docs Tracking issue: rust-lang#156756 This follows up on the initial unstable `Share` trait added in rust-lang#156828. The original API used an ordinary default method: ```rust fn share(&self) -> Self { Clone::clone(self) } ``` Niko pointed out that `share` should be final, since `Share` is meant to communicate the semantics of `Clone::clone` for clone-as-alias types, not provide a second independently-overridable operation. `Share` remains unstable under `#![feature(share_trait)]`. r? @nikomatsakis

…uwer Rollup of 23 pull requests Successful merges: - #144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - #153238 (debuginfo: slices are DW_TAG_array_type's) - #157112 (Update aarch64-unknown-freebsd target description) - #157322 (test pre-stabilization items on CI) - #157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - #157490 (Add field-wise CoerceShared reborrow tests) - #157655 (Make Share::share final and improve docs) - #157672 (Region inference: Simplify initialisation of region values) - #157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - #157796 (rustdoc: Some more lazy formatting) - #157818 (miri subtree update) - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - #157079 (Don't recover `&raw EXPR` as a missing comma) - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - #157622 (Disable retagging for variadic arguments in const-eval) - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - #157695 (Extend capabilities of `TypeFoldable_Generic`) - #157766 (interpret: avoid computing layout of sized raw pointee) - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - #157795 (revert 157013) - #157798 (Prevent approving PRs that wait for Crater or formal decisions) - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

@nikomatsakis

Rollup merge of #157655 - P8L1:share-trait-final-docs, r=nikomatsakis Make Share::share final and improve docs Tracking issue: #156756 This follows up on the initial unstable `Share` trait added in #156828. The original API used an ordinary default method: ```rust fn share(&self) -> Self { Clone::clone(self) } ``` Niko pointed out that `share` should be final, since `Share` is meant to communicate the semantics of `Clone::clone` for clone-as-alias types, not provide a second independently-overridable operation. `Share` remains unstable under `#![feature(share_trait)]`. r? @nikomatsakis

…uwer Rollup of 23 pull requests Successful merges: - rust-lang/rust#144220 (Add powerpc64-unknown-linux-gnuelfv2 target) - rust-lang/rust#153238 (debuginfo: slices are DW_TAG_array_type's) - rust-lang/rust#157112 (Update aarch64-unknown-freebsd target description) - rust-lang/rust#157322 (test pre-stabilization items on CI) - rust-lang/rust#157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation) - rust-lang/rust#157490 (Add field-wise CoerceShared reborrow tests) - rust-lang/rust#157655 (Make Share::share final and improve docs) - rust-lang/rust#157672 (Region inference: Simplify initialisation of region values) - rust-lang/rust#157680 (Require `#[pin_v2]` for explicit pin-projection patterns) - rust-lang/rust#157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images) - rust-lang/rust#157796 (rustdoc: Some more lazy formatting) - rust-lang/rust#157818 (miri subtree update) - rust-lang/rust#157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT) - rust-lang/rust#157079 (Don't recover `&raw EXPR` as a missing comma) - rust-lang/rust#157202 (add #[rustc_no_writable] to slice::get_unchecked_mut) - rust-lang/rust#157622 (Disable retagging for variadic arguments in const-eval) - rust-lang/rust#157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver) - rust-lang/rust#157695 (Extend capabilities of `TypeFoldable_Generic`) - rust-lang/rust#157766 (interpret: avoid computing layout of sized raw pointee) - rust-lang/rust#157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia) - rust-lang/rust#157795 (revert 157013) - rust-lang/rust#157798 (Prevent approving PRs that wait for Crater or formal decisions) - rust-lang/rust#157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N)) Failed merges: - rust-lang/rust#157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))

Make Share::share final and improve docs

5004367

rustbot assigned nikomatsakis Jun 9, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 9, 2026

P8L1 mentioned this pull request Jun 9, 2026

Tracking Issue for Share trait #156756

Open

45 tasks

nikomatsakis mentioned this pull request Jun 10, 2026

Ergonomic ref-counting rust-lang/rust-project-goals#107

Open

13 tasks

nikomatsakis approved these changes Jun 10, 2026

View reviewed changes

Comment thread library/core/src/clone.rs Outdated

Update library/core/src/clone.rs

25e83a0

Co-authored-by: Niko Matsakis <niko@alum.mit.edu>

P8L1 requested a review from nikomatsakis June 12, 2026 08:17

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026

JonathanBrouwer mentioned this pull request Jun 12, 2026

Rollup of 14 pull requests #157809

Closed

JonathanBrouwer mentioned this pull request Jun 12, 2026

Rollup of 17 pull requests #157815

Closed

This was referenced Jun 12, 2026

Rollup of 23 pull requests #157827

Closed

Rollup of 23 pull requests #157828

Merged

rust-bors Bot merged commit 3bfbba5 into rust-lang:main Jun 12, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Make Share::share final and improve docs#157655

Make Share::share final and improve docs#157655
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
P8L1:share-trait-final-docs

P8L1 commented Jun 9, 2026 •

edited by rustbot

Loading

Uh oh!

Uh oh!

nikomatsakis commented Jun 10, 2026

Uh oh!

P8L1 commented Jun 12, 2026 •

edited

Loading

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

P8L1 commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

P8L1 commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

nikomatsakis commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

P8L1 commented Jun 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nikomatsakis commented Jun 10, 2026

Uh oh!

P8L1 commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

P8L1 commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

P8L1 commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

nikomatsakis commented Jun 12, 2026

Uh oh!

rust-bors Bot commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

P8L1 commented Jun 9, 2026 •

edited by rustbot

Loading

P8L1 commented Jun 12, 2026 •

edited

Loading