Skip to content

test pre-stabilization items on CI#157322

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lqd:ci-new-solver-bootstrapping
Jun 12, 2026
Merged

test pre-stabilization items on CI#157322
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
lqd:ci-new-solver-bootstrapping

Conversation

@lqd

@lqd lqd commented Jun 2, 2026

Copy link
Copy Markdown
Member

View all comments

This PR is part of MCP 996, and adds a new CI job dedicated to testing pre-stabilization items, with:

  • the new solver, to ensure it can build the standard library (moved from where I added it in test new solver on CI until stabilization #156146). Note this is not sufficient yet, as we also want to test bootstrapping soon, but it's currently broken and will have to wait for a followup PR.
  • the polonius alpha, by running UI tests under the polonius compare-mode

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 2, 2026
@lqd lqd force-pushed the ci-new-solver-bootstrapping branch from c99871d to 2ccb086 Compare June 2, 2026 16:18
@lqd

This comment was marked as outdated.

@lqd lqd force-pushed the ci-new-solver-bootstrapping branch 2 times, most recently from cf12d63 to a1e46bc Compare June 3, 2026 09:13
@rust-log-analyzer

This comment has been minimized.

@lqd

This comment was marked as outdated.

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 4, 2026
test pre-stabilization items on CI


try-job: x86_64-gnu-pre-stabilization
@rust-bors

This comment was marked as outdated.

@lqd lqd force-pushed the ci-new-solver-bootstrapping branch from 7f7da58 to b0dae5c Compare June 8, 2026 13:19
@lqd

lqd commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-gnu-pre-stabilization

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 8, 2026
test pre-stabilization items on CI


try-job: x86_64-gnu-pre-stabilization
@rust-bors

rust-bors Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d8c4174 (d8c41744a5ac790c62c80391bd3a00b5ea71e7ec, parent: 06293ff2b120aecfc29f84b90a22a743a5b90fef)

@lqd lqd marked this pull request as ready for review June 11, 2026 17:15
@rustbot

rustbot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2026
@rustbot

rustbot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

@lqd

lqd commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

rust-lang/compiler-team#996 (comment) is accepted, this is ready to review.

r? @Kobzol or @marcoieni

@rustbot rustbot assigned Kobzol and unassigned marcoieni Jun 11, 2026
@rustbot

rustbot commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol

Kobzol commented Jun 11, 2026

Copy link
Copy Markdown
Member

Can you please add a doc_url to the job that either points to this file (on main), or to a rdg entry about this job? Since the latter does not exist, the former will be easier :)

To give a quick link that points to a bootstrap command to try locally when the job fails.

After that you can r=me.

@lqd lqd force-pushed the ci-new-solver-bootstrapping branch from b0dae5c to bbfa6fb Compare June 12, 2026 08:19
@rustbot

rustbot commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lqd

lqd commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

(I force-pushed to fix a typo, but the job worked in the prior push)

Comment thread src/ci/github-actions/jobs.yml Outdated
- Moves the existing new solver stdlib testing to that job. Bootstrapping
  will also be need to be tested in the near future.
- Also tests the polonius alpha, by running the UI tests under the polonius compare-mode
@lqd lqd force-pushed the ci-new-solver-bootstrapping branch from 708f7c8 to 6e1de07 Compare June 12, 2026 12:20
@lqd

lqd commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Thanks @jieyouxu for the doc!

@Kobzol

Kobzol commented Jun 12, 2026

Copy link
Copy Markdown
Member

Thank you both!

@bors r=kobzol,jieyouxu

Let's race a try build, just in case.

@bors try jobs=x86_64-gnu-pre-stabilization

@rust-bors

rust-bors Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6e1de07 has been approved by kobzol,jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026
test pre-stabilization items on CI


try-job: x86_64-gnu-pre-stabilization

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this also seems reasonable to me

View changes since this review

@jieyouxu

Copy link
Copy Markdown
Member

@rust-bors

rust-bors Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 50280fd (50280fdd16db377ba4c24225d37310b9d9d9455f, parent: 09a371361240e42b0d69438fd1179efcf212e576)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 12, 2026
…=kobzol,jieyouxu

test pre-stabilization items on CI

This PR is part of [MCP 996](rust-lang/compiler-team#996), and adds a new CI job dedicated to testing pre-stabilization items, with:
- the new solver, to ensure it can build the standard library (moved from where I added it in rust-lang#156146). Note this is not sufficient _yet_, as we also want to test bootstrapping soon, but it's currently broken and will have to wait for a followup PR.
- the polonius alpha, by running UI tests under the polonius compare-mode
rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026
…uwer

Rollup of 17 pull requests

Successful merges:

 - #156950 (Staticlib rename internal symbols)
 - #157322 (test pre-stabilization items on CI)
 - #157490 (Add field-wise CoerceShared reborrow tests)
 - #157655 (Make Share::share final and improve docs)
 - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images)
 - #157796 (rustdoc: Some more lazy formatting)
 - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT)
 - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut)
 - #157622 (Disable retagging for variadic arguments in const-eval)
 - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver)
 - #157695 (Extend capabilities of `TypeFoldable_Generic`)
 - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))
 - #157766 (interpret: avoid computing layout of sized raw pointee)
 - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia)
 - #157795 (revert 157013)
 - #157798 (Prevent approving PRs that wait for Crater or formal decisions)
 - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))
rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026
…uwer

Rollup of 17 pull requests

Successful merges:

 - #156950 (Staticlib rename internal symbols)
 - #157322 (test pre-stabilization items on CI)
 - #157490 (Add field-wise CoerceShared reborrow tests)
 - #157655 (Make Share::share final and improve docs)
 - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images)
 - #157796 (rustdoc: Some more lazy formatting)
 - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT)
 - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut)
 - #157622 (Disable retagging for variadic arguments in const-eval)
 - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver)
 - #157695 (Extend capabilities of `TypeFoldable_Generic`)
 - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))
 - #157766 (interpret: avoid computing layout of sized raw pointee)
 - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia)
 - #157795 (revert 157013)
 - #157798 (Prevent approving PRs that wait for Crater or formal decisions)
 - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 12, 2026
…=kobzol,jieyouxu

test pre-stabilization items on CI

This PR is part of [MCP 996](rust-lang/compiler-team#996), and adds a new CI job dedicated to testing pre-stabilization items, with:
- the new solver, to ensure it can build the standard library (moved from where I added it in rust-lang#156146). Note this is not sufficient _yet_, as we also want to test bootstrapping soon, but it's currently broken and will have to wait for a followup PR.
- the polonius alpha, by running UI tests under the polonius compare-mode
rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026
…uwer

Rollup of 23 pull requests

Successful merges:

 - #144220 (Add powerpc64-unknown-linux-gnuelfv2 target)
 - #153238 (debuginfo: slices are DW_TAG_array_type's)
 - #157112 (Update aarch64-unknown-freebsd target description)
 - #157322 (test pre-stabilization items on CI)
 - #157348 (Don't track cwd for `-Zremap-cwd-prefix` in incremental compilation)
 - #157490 (Add field-wise CoerceShared reborrow tests)
 - #157655 (Make Share::share final and improve docs)
 - #157672 (Region inference: Simplify initialisation of region values)
 - #157680 (Require `#[pin_v2]` for explicit pin-projection patterns)
 - #157688 (Create experimental test job `aarch64-apple-macos-26` for evaluating `macos-26` runner images)
 - #157796 (rustdoc: Some more lazy formatting)
 - #157818 (miri subtree update)
 - #157069 (Test that you can't implement Unpin for a compiler-generated future using TAIT)
 - #157079 (Don't recover `&raw EXPR` as a missing comma)
 - #157202 (add #[rustc_no_writable] to slice::get_unchecked_mut)
 - #157622 (Disable retagging for variadic arguments in const-eval)
 - #157684 (-Zassumptions-on-binders: insert empty assumptions when entering binders in the solver)
 - #157695 (Extend capabilities of `TypeFoldable_Generic`)
 - #157766 (interpret: avoid computing layout of sized raw pointee)
 - #157785 (fuchsia: Support AddressSanitizer on riscv64gc-unknown-fuchsia)
 - #157795 (revert 157013)
 - #157798 (Prevent approving PRs that wait for Crater or formal decisions)
 - #157803 (Rename `errors.rs` file to `diagnostics.rs` (7/N))

Failed merges:

 - #157752 (Rename `errors.rs` file to `diagnostics.rs` (6/N))
@rust-bors rust-bors Bot merged commit 460c711 into rust-lang:main Jun 12, 2026
14 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 12, 2026
rust-timer added a commit that referenced this pull request Jun 13, 2026
Rollup merge of #157322 - lqd:ci-new-solver-bootstrapping, r=kobzol,jieyouxu

test pre-stabilization items on CI

This PR is part of [MCP 996](rust-lang/compiler-team#996), and adds a new CI job dedicated to testing pre-stabilization items, with:
- the new solver, to ensure it can build the standard library (moved from where I added it in #156146). Note this is not sufficient _yet_, as we also want to test bootstrapping soon, but it's currently broken and will have to wait for a followup PR.
- the polonius alpha, by running UI tests under the polonius compare-mode
@lqd lqd deleted the ci-new-solver-bootstrapping branch June 13, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants