Fix sample code for std::offload at usage.md#156667
Closed
sgasho wants to merge 1 commit into
Closed
Conversation
Collaborator
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
rustbot
added
A-rustc-dev-guide
ZuseZ4
approved these changes
May 18, 2026
Member
|
Oh wait, I just see that you're making the or against r-l/r |
Contributor
Author
|
I see, I created a PR at dev guide here: rust-lang/rustc-dev-guide#2874 |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample code at src/doc/rustc-dev-guide/src/offload/usage.md did not work on an NVIDIA gpu server.
It seems it has a typo. _kernel_1 was not defined but referenced at core::intrinsics::offload.
I replaced it with kernel_1 and it worked.
r? @ZuseZ4