Skip to content

Rollup of 3 pull requests#154845

Closed
JonathanBrouwer wants to merge 13 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-IV4UJts
Closed

Rollup of 3 pull requests#154845
JonathanBrouwer wants to merge 13 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-IV4UJts

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

chenyukang and others added 13 commits April 1, 2026 10:06
…rn-assignment-help, r=Kivooeo

Fix pattern assignment suggestions for uninitialized bindings

Fixes rust-lang#145564
…message, r=jdonszelmann

fix(lints): Improve `ill_formed_attribute_input` with better help message

Add a better help message to `ill_formed_attribute_input` for the cases where it matches the usage of `#![allow]`.

For further details see rust-lang#154667

closes rust-lang#154667

cc: @Zalathar
…onszelmann

Post-attribute ports cleanup pt. 1

r? @jdonszelmann

This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES

All commits do one thing and every commit passes tests, so best reviewed commit by commit
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Apr 5, 2026
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 5, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 66351ea has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026
@rust-bors

rust-bors Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit 66351ea with merge bef2294...

Workflow: https://github.com/rust-lang/rust/actions/runs/24001911572

rust-bors Bot pushed a commit that referenced this pull request Apr 5, 2026
…uwer

Rollup of 3 pull requests

Successful merges:

 - #154657 (Fix pattern assignment suggestions for uninitialized bindings)
 - #154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message)
 - #154808 (Post-attribute ports cleanup pt. 1)
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 5, 2026
@rust-bors

rust-bors Bot commented Apr 5, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved due to being closed.

Auto build was cancelled due to the PR being closed. Cancelled workflows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants