Skip to content

Run rustdoc tests in opt-dist tests#150534

Merged
bors merged 1 commit into
rust-lang:mainfrom
Kobzol:dist-test-rustdoc
Jan 2, 2026
Merged

Run rustdoc tests in opt-dist tests#150534
bors merged 1 commit into
rust-lang:mainfrom
Kobzol:dist-test-rustdoc

Conversation

@Kobzol

@Kobzol Kobzol commented Dec 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Context: #150287

try-job: dist-x86_64-linux

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 31, 2025
@Kobzol

Kobzol commented Dec 31, 2025

Copy link
Copy Markdown
Member Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot added a commit that referenced this pull request Dec 31, 2025
@rust-bors
Auto merge of #150534 - Kobzol:dist-test-rustdoc, r=<try>
4872b81 
Run rustdoc tests in opt-dist tests

try-job: dist-x86_64-linux
@rust-bors

rust-bors Bot commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 4872b81 (4872b815ac3093154ffb956affe6951ff18e66fe, parent: ab32c26b49eacb1b694972bb29d20167bdbdfc51)

@Kobzol Kobzol mentioned this pull request Dec 31, 2025
Open
@Kobzol

Kobzol commented Jan 2, 2026

Copy link
Copy Markdown
Member Author

Running these tests takes ~20s, so it should be fine to just run them always.

r? @Urgau

@Kobzol Kobzol marked this pull request as ready for review January 2, 2026 08:55
@rustbot

rustbot commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 2, 2026
@Urgau

Urgau commented Jan 2, 2026

Copy link
Copy Markdown
Member

Indeed, they only ~20s. https://triage.rust-lang.org/gha-logs/rust-lang/rust/59209398254#L2025-12-31T12:30:44.5062692Z-L2025-12-31T12:31:02.7405328Z

Urgau
Urgau approved these changes Jan 2, 2026
View reviewed changes

@Urgau Urgau left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

View changes since this review

@Urgau

Urgau commented Jan 2, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 03d2bcc has been approved by Urgau

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2026
@bors

bors commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 03d2bcc with merge 8a24a20...

jyn514
jyn514 reviewed Jan 2, 2026
View reviewed changes
Comment thread src/tools/opt-dist/src/tests.rs
@bors

bors commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Urgau
Pushing 8a24a20 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 2, 2026
@bors bors merged commit 8a24a20 into rust-lang:main Jan 2, 2026
13 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 2, 2026
@Kobzol Kobzol deleted the dist-test-rustdoc branch January 2, 2026 16:28
@github-actions

github-actions Bot commented Jan 2, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bf6b5b9 (parent) -> 8a24a20 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8a24a202aa02f677fc2a3e0e1a69af7545803952 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7415.9s -> 9354.3s (+26.1%)
  2. dist-x86_64-solaris: 5094.8s -> 5960.6s (+17.0%)
  3. aarch64-gnu-debug: 4362.3s -> 3716.4s (-14.8%)
  4. x86_64-rust-for-linux: 3034.3s -> 2594.2s (-14.5%)
  5. x86_64-gnu-tools: 3669.6s -> 3153.2s (-14.1%)
  6. dist-x86_64-apple: 7628.1s -> 8684.9s (+13.9%)
  7. x86_64-gnu-gcc: 3492.2s -> 3030.3s (-13.2%)
  8. x86_64-gnu-llvm-20-1: 4344.2s -> 3789.7s (-12.8%)
  9. dist-sparcv9-solaris: 5187.2s -> 5844.7s (+12.7%)
  10. pr-check-1: 1871.0s -> 1634.1s (-12.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Kobzol Kobzol mentioned this pull request Jan 2, 2026
Draft
@rust-timer

rust-timer commented Jan 2, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8a24a20): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-3.3%, -2.4%] 3
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.964s -> 473.485s (-0.10%)
Artifact size: 390.78 MiB -> 390.77 MiB (-0.00%)

@github-actions github-actions Bot mentioned this pull request Jan 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

+1 more reviewer

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Urgau Urgau

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol @rustbot @Urgau @bors @rust-timer @jyn514