Skip to content

Port #[instruction_set] to attribute parser#150193

Merged
bors merged 1 commit into
rust-lang:mainfrom
Bryntet:parse_instruction_set
Dec 31, 2025
Merged

Port #[instruction_set] to attribute parser#150193
bors merged 1 commit into
rust-lang:mainfrom
Bryntet:parse_instruction_set

Conversation

@Bryntet

@Bryntet Bryntet commented Dec 20, 2025

Copy link
Copy Markdown
Contributor

Please note the test changes, and deprecation of E0778 and E0779

In my opinion, all errors related to this attribute are improved I think, except for if you have #[instruction_set(arm::)] in which case there's an error: expected identifier, found <eof>, which is quite unhelpful I think, but this seems to be a limitation of the general attribute parsing flow

r? @JonathanBrouwer

@rustbot

rustbot commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2025
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer requested changes Dec 20, 2025
View reviewed changes
Comment thread compiler/rustc_attr_parsing/src/attributes/instruction_set.rs Outdated
Comment thread compiler/rustc_attr_parsing/src/attributes/instruction_set.rs Outdated
Comment thread compiler/rustc_attr_parsing/src/attributes/instruction_set.rs Outdated
Comment thread compiler/rustc_attr_parsing/messages.ftl Outdated
Comment thread compiler/rustc_error_codes/src/error_codes/E0778.md
Comment thread compiler/rustc_error_codes/src/error_codes/E0779.md
Comment thread tests/ui/attributes/instruction-set.stderr
Comment thread tests/ui/attributes/instruction-set.stderr
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2025
@rustbot

rustbot commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Bryntet Bryntet force-pushed the parse_instruction_set branch 4 times, most recently from 2815243 to 25f9a74 Compare December 20, 2025 16:42
@Bryntet

Bryntet commented Dec 20, 2025

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 20, 2025
JonathanBrouwer
JonathanBrouwer reviewed Dec 20, 2025
View reviewed changes
Comment thread compiler/rustc_error_codes/src/error_codes/E0778.md
@Bryntet Bryntet force-pushed the parse_instruction_set branch from 25f9a74 to 6fd2c64 Compare December 20, 2025 17:19
JonathanBrouwer
JonathanBrouwer reviewed Dec 20, 2025
View reviewed changes
Comment thread tests/ui/attributes/instruction-set.rs Outdated
@Bryntet Bryntet force-pushed the parse_instruction_set branch from 6fd2c64 to d42c32b Compare December 20, 2025 17:32
@JonathanBrouwer

JonathanBrouwer commented Dec 20, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit d42c32b has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2025
@JonathanBrouwer

JonathanBrouwer commented Dec 20, 2025

Copy link
Copy Markdown
Contributor

@bors r-
Sorry one more thing

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2025
JonathanBrouwer
JonathanBrouwer reviewed Dec 20, 2025
View reviewed changes
Comment thread compiler/rustc_attr_parsing/src/attributes/instruction_set.rs Outdated
@Bryntet Bryntet force-pushed the parse_instruction_set branch from d42c32b to 0516456 Compare December 20, 2025 18:06
@bors

bors commented Dec 28, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2025
@JonathanBrouwer

JonathanBrouwer commented Dec 28, 2025

Copy link
Copy Markdown
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2025
@Bryntet Bryntet force-pushed the parse_instruction_set branch from 8df47f0 to a355714 Compare December 29, 2025 11:39
@JonathanBrouwer

JonathanBrouwer commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

@bors try jobs=arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot added a commit that referenced this pull request Dec 29, 2025
@rust-bors
Auto merge of #150193 - Bryntet:parse_instruction_set, r=<try>
d37304f 
Port `#[instruction_set]` to attribute parser

try-job: arm-android
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d37304f (d37304fec15959f677537b7dac3df542d70c06ce, parent: 112a274275d77ebc2b892f056a1e2fad141f4f08)

@Bryntet Bryntet force-pushed the parse_instruction_set branch from a355714 to a95d41d Compare December 30, 2025 19:42
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryntet Bryntet force-pushed the parse_instruction_set branch from a95d41d to acd6ba4 Compare December 31, 2025 02:01
@JonathanBrouwer

JonathanBrouwer commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

@bors try jobs=arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot added a commit that referenced this pull request Dec 31, 2025
@rust-bors
Auto merge of #150193 - Bryntet:parse_instruction_set, r=<try>
760e57a 
Port `#[instruction_set]` to attribute parser

try-job: arm-android
@rust-bors

rust-bors Bot commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 760e57a (760e57a80050bf1b8884e69c02da01f82cddc12b, parent: ab32c26b49eacb1b694972bb29d20167bdbdfc51)

@JonathanBrouwer

JonathanBrouwer commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup=iffy
Iffy because this has ARM-specific tests which failed in rollup before

@bors

bors commented Dec 31, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit acd6ba4 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 31, 2025
Merged
bors added a commit that referenced this pull request Dec 31, 2025
@bors
Auto merge of #150542 - JonathanBrouwer:rollup-3fjgrji, r=JonathanBro…
a2bc948 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #150193 (Port `#[instruction_set]` to attribute parser)
 - #150511 (Allow inline calls to offload intrinsic)
 - #150539 (Corretly link URL in internal Windows docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5183d8f into rust-lang:main Dec 31, 2025
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 31, 2025
rust-timer added a commit that referenced this pull request Dec 31, 2025
@rust-timer
Unrolled build for #150193
140e9fc 
Rollup merge of #150193 - Bryntet:parse_instruction_set, r=JonathanBrouwer

Port `#[instruction_set]` to attribute parser

Please note the test changes, and deprecation of `E0778` and `E0779`

In my opinion, all errors related to this attribute are improved I think, except for if you have `#[instruction_set(arm::)]` in which case there's an `error: expected identifier, found <eof>`, which is quite unhelpful I think, but this seems to be a limitation of the general attribute parsing flow

r? `@JonathanBrouwer`
@jdonszelmann jdonszelmann mentioned this pull request Jan 10, 2026
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer Awaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Bryntet @rustbot @rust-log-analyzer @JonathanBrouwer @bors