Skip to content

AliasRelate: don't discard constraints on overflow#148069

Closed
lcnr wants to merge 3 commits into
rust-lang:mainfrom
lcnr:alias-relate-no-discard-constraints
Closed

AliasRelate: don't discard constraints on overflow#148069
lcnr wants to merge 3 commits into
rust-lang:mainfrom
lcnr:alias-relate-no-discard-constraints

Conversation

@lcnr

@lcnr lcnr commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 24, 2025
@bors

bors commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #148066) made this pull request unmergeable. Please resolve the merge conflicts.

jdonszelmann
jdonszelmann reviewed Nov 5, 2025
View reviewed changes
Comment thread compiler/rustc_type_ir/src/solve/mod.rs Outdated
jdonszelmann
jdonszelmann reviewed Nov 5, 2025
View reviewed changes
Comment thread compiler/rustc_type_ir/src/search_graph/mod.rs Outdated
jdonszelmann
jdonszelmann reviewed Nov 5, 2025
View reviewed changes
Comment thread compiler/rustc_next_trait_solver/src/solve/eval_ctxt/mod.rs
// won't be a breaking change, so this is good enough for now.
return Ok(self.make_ambiguous_response_no_constraints(cause, opaque_types_jank));
match self.current_goal_kind {
CurrentGoalKind::AliasRelate | CurrentGoalKind::NormalizesTo => {}

@jdonszelmann jdonszelmann Nov 5, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right so here you'd have previously discarded (since AliasRelate got CurrentGoalKind::Misc but now you take this top branch). I'm not 100% sure why you also go here for NormalizesTo. That'd have previously discarded.

@lcnr lcnr Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd have previously discarded.

they wouldn't have, because for NormalizesTo we use the shallow_certainty due to the above match (self.current_goal_kind, shallow_certainty). That's subtle though

@jdonszelmann jdonszelmann Nov 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe document it?

@jdonszelmann jdonszelmann Nov 5, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or somehow combine the two checks, such that all the ways in which we care about self.current_goal_kind are handled exhaustively. I'm not sure that ends up working though, could also turn out more confusing rather than less

@jdonszelmann jdonszelmann Nov 5, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried: combining doesn't produce a nice check, maybe just document?

@jdonszelmann jdonszelmann force-pushed the alias-relate-no-discard-constraints branch from 3620c77 to eaf4dbd Compare November 5, 2025 11:55
@jdonszelmann jdonszelmann mentioned this pull request Nov 6, 2025
Open
@bors

bors commented Nov 9, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #148721) made this pull request unmergeable. Please resolve the merge conflicts.

@jdonszelmann jdonszelmann force-pushed the alias-relate-no-discard-constraints branch from eaf4dbd to a45a475 Compare November 10, 2025 11:07
@jdonszelmann

jdonszelmann commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

(rebased, I was doing some rebasing anyway)

@rust-log-analyzer

rust-log-analyzer commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
  PR_CI_JOB: 1
  SKIP_SUBMODULES: src/gcc
  IMAGE: tidy
##[endgroup]
error: PRs changing the `nightly` channel should be sent to the `master` branch!
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@jdonszelmann

jdonszelmann commented Nov 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

spurious?

PRs changing the nightly channel should be sent to the master branch!

we changed to main ofc

see: #148564

@bors

bors commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #149397) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr lcnr mentioned this pull request May 1, 2026
Open
@inq

inq commented May 13, 2026

Copy link
Copy Markdown
Contributor

Can I revive this PR?

r? @lcnr

@rustbot

rustbot commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Pull request author cannot be assigned as reviewer.

Please choose another assignee.

@lcnr

lcnr commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

This will change with our normalization refactors regardless and might end up unnecessary for stabilization Closing for now

@lcnr lcnr closed this Jun 4, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdonszelmann jdonszelmann jdonszelmann left review comments

Assignees

@BoxyUwU BoxyUwU

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ml-kem-0.2.1 incorrect overflow error

7 participants

@lcnr @bors @jdonszelmann @rust-log-analyzer @inq @rustbot @BoxyUwU