Initial UnsafePinned implementation [Part 1: Libs]#137043
Merged
Merged
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Sky9x
changed the title
UnsafePinned impl [Part 1: Libs]UnsafePinned implementation [Part 1: Libs]
Sky9x
force-pushed
the
unsafe-pinned-pt1-libs
branch
from
e823a89 to
97308a2
Compare
Contributor
|
Cc @rust-lang/libs-api, this unstably adds the interfaces from the accepted RFC https://rust-lang.github.io/rfcs/3467-unsafe-pinned.html. |
tgross35
reviewed
Feb 23, 2025
Sky9x
force-pushed
the
unsafe-pinned-pt1-libs
branch
2 times, most recently
from
24af599 to
9ec74c7
Compare
This comment has been minimized.
This comment has been minimized.
Sky9x
force-pushed
the
unsafe-pinned-pt1-libs
branch
from
9ec74c7 to
74efc47
Compare
This comment has been minimized.
This comment has been minimized.
Sky9x
force-pushed
the
unsafe-pinned-pt1-libs
branch
from
74efc47 to
c42e42c
Compare
Collaborator
|
☔ The latest upstream changes (presumably #138366) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
reviewed
Mar 18, 2025
tgross35
left a comment
tgross35
left a comment
Contributor
There was a problem hiding this comment.
This API appears to match RFC 3467 so I think it is good to go. The docs could probably use elaboration at some point, but that should be fine to defer until the feature is fully available.
r=me with one doc request and conflicts resolved.
Cc @WaffleLapkin @RalfJung if you have anything else.
Member
|
compiler changes LGTM. |
Contributor
|
@rustbot author for #137043 (review) |
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial libs changes necessary to unblock further work on RFC 3467.
Tracking issue: #125735
This PR is split off from #136964, and includes just the libs changes:
UnsafePinnedstructUnsafeUnpinstructural auto traitUnsafePinnedThis PR does not change codegen, miri, the existing
!Unpinhack, or anything else. That work is to be split into later PRs.cc @RalfJung @Noratrieb
@rustbot label F-unsafe_pinned T-libs-api