Remove rustc's std copy#128986
Conversation
rustbot
added
S-waiting-on-review
|
Could you please comment this line in this PR, to enable post-optimization tests in the x64 Linux dist runner? Then we can try the dist tests in try builds. |
|
This PR is still a WIP in order to run tests/debug/try alternatives on builders, right? As it currently looks like dd3f757 which failed in the previous PR. |
|
I haven't tracked down the reason for the test failure yet. Does post-optimization tests specify the final binary as stage0-sysroot? Then runs tests as stage0 with a new std build? |
|
Yeah, post-optimization tests essentially take the sysroot created in the |
|
I tried to move forward with this in #112049. Currently, incremental dist tests fail on Windows when the libstd.dll file is missing (maybe it's due to some bug, e.g. too many DLL files are being removed). Trying to investigate. |
|
Posted #131188 with some additional modifications. |
|
Ah so we still don’t really know what’s going on to fix it "properly" on windows as well? |
|
I have no idea why the tests fail on Windows :( https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Failing.20incr.20tests.20on.20Windows.20when.20std.2Edll.20is.20missing/near/474507064 |
…, r=onur-ozkan Do not copy libstd dynamic library to sysroot Since rust-lang#122362, rustc links statically to libstd.[so|dll]. Which means that the libstd.[so|dll] file no longer has to be in the rustc sysroot. However, we are currently still shipping this file, in every new release of Rust, for no reason, it's just wasted bytes. This PR removes the dynamic library file from the built sysroot. However, it is not yet performed on Windows, because stage0 incremental tests start failing there (see description of the issue [here](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Failing.20incr.20tests.20on.20Windows.20when.20std.2Edll.20is.20missing/near/474507064)). This is an extended version of rust-lang#128986. CC `@Zoxc`
|
Probably can be closed now that #131188 was merged. |
|
☔ The latest upstream changes (presumably #131188) made this pull request unmergeable. Please resolve the merge conflicts. |
…ozkan Do not copy libstd dynamic library to sysroot Since rust-lang/rust#122362, rustc links statically to libstd.[so|dll]. Which means that the libstd.[so|dll] file no longer has to be in the rustc sysroot. However, we are currently still shipping this file, in every new release of Rust, for no reason, it's just wasted bytes. This PR removes the dynamic library file from the built sysroot. However, it is not yet performed on Windows, because stage0 incremental tests start failing there (see description of the issue [here](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Failing.20incr.20tests.20on.20Windows.20when.20std.2Edll.20is.20missing/near/474507064)). This is an extended version of rust-lang/rust#128986. CC `@Zoxc`
5 participants
This removes rustc's std copy if we're statically linking
stdintorustc_driver. This copy is not needed after #122362.try-job: dist-x86_64-linux
try-job: dist-x86_64-msvc