change snapshot tracking in fulfillment contexts

[lcnr]

use the exact snapshot number to prevent misuse even when created inside of a snapshot

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in const_evaluatable.rs

cc @BoxyUwU

[lcnr]

@bors try @rust-timer queue

[bors]

⌛ Trying commit d04775d with merge f93fa484ba0ec403938990b190c4fd5ae53b7a18...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[lcnr]

what's happening with bors rn, both here and in #113150? it seems like the runs just get cancelled for no reason 🤔 cc @rust-lang/infra-bors

[Kobzol]

Parallel try builds are temporarily broken (they will be cancelled), until #113059 gets merged. CC @pietroalbini

[compiler-errors]

@bors try

[bors]

⌛ Trying commit d04775d with merge 90c2b525eb095f8c5841cd99315173668f83f699...

[bors]

☀️ Try build successful - checks-actions
Build commit: 90c2b525eb095f8c5841cd99315173668f83f699 (90c2b525eb095f8c5841cd99315173668f83f699)

[rust-timer]

Finished benchmarking commit (90c2b525eb095f8c5841cd99315173668f83f699): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[0.4%, 3.9%]	4
Regressions ❌ (secondary)	1.2%	[1.1%, 1.4%]	2
Improvements ✅ (primary)	-1.2%	[-2.4%, -0.5%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[-2.4%, 3.9%]	7

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.5%, 1.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.5%, 1.1%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 662.146s -> 660.849s (-0.20%)

[compiler-errors]

@bors r+

[bors]

📌 Commit d04775d has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit d04775d with merge 7383ab7...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 7383ab7 to master...

[rust-timer]

Finished benchmarking commit (7383ab7): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[0.5%, 5.8%]	9
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[0.5%, 5.8%]	9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.2%]	2
All ❌✅ (primary)	0.0%	[-0.5%, 0.5%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 661.363s -> 661.53s (0.03%)