Skip to content

Make hidden type registration opt-in, so that each site can be reviewed on its own and we have the right defaults for trait solvers#108311

Merged
bors merged 1 commit into
rust-lang:masterfrom
oli-obk:invert_defines
Feb 21, 2023
Merged

Conversation

@oli-obk

@oli-obk oli-obk commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

r? @lcnr

pulled out of #107891 as it is the uncontroversial part

…ed on its own and we have the right defaults for trait solvers
@rustbot

rustbot commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Feb 21, 2023
@rustbot

rustbot commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr, @compiler-errors

@oli-obk

oli-obk commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

@bors rollup=never (for bisectability)

@lcnr

lcnr commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

had a crater run in #107891

@bors r+

@bors

bors commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 88a7b68 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2023
@bors

bors commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 88a7b68 with merge f4c7596...

@bors

bors commented Feb 21, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing f4c7596 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 21, 2023
@bors bors merged commit f4c7596 into rust-lang:master Feb 21, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 21, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f4c7596): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.0%, 3.1%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants