Skip to content

Bump thin-vec version to pick up inline attributes#108245

Closed
Zoxc wants to merge 1 commit into
rust-lang:masterfrom
Zoxc:thin-vec-bump
Closed

Bump thin-vec version to pick up inline attributes#108245
Zoxc wants to merge 1 commit into
rust-lang:masterfrom
Zoxc:thin-vec-bump

Conversation

@Zoxc

@Zoxc Zoxc commented Feb 19, 2023

Copy link
Copy Markdown
Contributor

This bumps the thin-vec version to pick up mozilla/thin-vec#44 since the len method was not inlined in the query system.

@rustbot

rustbot commented Feb 19, 2023

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2023
@rustbot

rustbot commented Feb 19, 2023

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@Noratrieb

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2023
@bors

bors commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 06593900cc647c3eed0c4e8211e6011d4b991e4e with merge 0ce21dd312fae07a51e5e16e0e430d5f40a7f68a...

@bors

bors commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 0ce21dd312fae07a51e5e16e0e430d5f40a7f68a (0ce21dd312fae07a51e5e16e0e430d5f40a7f68a)

1 similar comment
@bors

bors commented Feb 20, 2023

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 0ce21dd312fae07a51e5e16e0e430d5f40a7f68a (0ce21dd312fae07a51e5e16e0e430d5f40a7f68a)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0ce21dd312fae07a51e5e16e0e430d5f40a7f68a): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2023
@Zoxc

Zoxc commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

Let's make that v0.2.12 to pick up mozilla/thin-vec#45 too.

@klensy

klensy commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

this already updated by #104754 ?

@Zoxc

Zoxc commented Feb 21, 2023

Copy link
Copy Markdown
Contributor Author

I guess it snuck in there.

@Zoxc Zoxc closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants