Add various strcase* functions and getline by palfrey · Pull Request #1130 · rust-lang/libc

palfrey · 2018-11-20T23:23:14Z

Adds

strcasestr
strcasecmp
strncasecmp
getline

I think they're semi-universal, but shall see what CI pops up...

rust-highfive · 2018-11-20T23:23:24Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

gnzlbg · 2018-11-20T23:36:02Z

It appears that the freebsd image used in CI lacks getline. Maybe a header is missing in the libc-test/build.rs for freebsd ? Otherwise you might want to take a look at whether more recent freebsd versions expose this.

…Unix

palfrey · 2018-11-20T23:53:08Z

@gnzlbg https://www.freebsd.org/cgi/man.cgi?query=getline&apropos=0&sektion=0&manpath=FreeBSD+8.2-RELEASE&format=html indicates FreeBSD 8.0+ has getline, but only if you define _WITH_GETLINE, so let's try that...

gnzlbg · 2018-11-20T23:55:59Z

r? @gnzlbg

@palfrey please ping me when CI is green

gnzlbg · 2018-11-21T00:36:07Z

@bors: r+

bors · 2018-11-21T00:36:08Z

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove [WIP] from this PR's title when it is ready for review.

gnzlbg · 2018-11-21T07:54:15Z

The windows msvc toolchains (the gnu ones are ok) are failing with:

C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(591): error C2065: 'strcasecmp': undeclared identifier
C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(591): warning C4047: 'return': 'int (__cdecl *)(const char *,const char *)' differs in levels of indirection from 'int'
C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(596): error C2065: 'strncasecmp': undeclared identifier
C:\projects\libc\target\x86_64-pc-windows-msvc\debug\build\libc-test-9926ed016ab2f41f\out\main.c(596): warning C4047: 'return': 'int (__cdecl *)(const char *,const char *,std::size_t)' differs in levels of indirection from 'int'

Could you take a look?

bors · 2018-11-21T23:12:50Z

☔ The latest upstream changes (presumably #1129) made this pull request unmergeable. Please resolve the merge conflicts.

gnzlbg · 2018-11-22T07:55:38Z

I think it would be good to add these to redox, cloudabi, etc. as well.

palfrey · 2018-11-23T21:27:50Z

I dug through https://github.com/redox-os/relibc and https://github.com/NuxiNL/cloudlibc and added all of these functions that I could find there, along with what I think is the right header support...

palfrey · 2018-11-23T23:29:02Z

Uh, so I think all the Travis failures are nothing to do with this branch e.g.

+docker build -t libc -f ci/docker/sparc64-unknown-linux-gnu/Dockerfile ci/
Sending build context to Docker daemon    107kB
Step 1/7 : FROM debian:stretch
stretch: Pulling from library/debian
age configuration: unknown blob

Can we kick it in some way to rebuild and try again?

gnzlbg · 2018-11-24T09:35:45Z

@bors: r+

bors · 2018-11-24T10:15:00Z

💔 Test failed - status-travis

gnzlbg · 2018-11-24T14:06:12Z

@bors: try

gnzlbg · 2018-11-24T14:07:22Z

@bors: retry

bors · 2018-11-24T14:07:29Z

⌛ Trying commit 75071fe with merge 6ef0a8e...

Add various strcase* functions and getline Adds * `strcasestr` * `strcasecmp` * `strncasecmp` * `getline` I *think* they're semi-universal, but shall see what CI pops up...

bors · 2018-11-24T14:27:09Z

💔 Test failed - status-travis

gnzlbg · 2018-11-24T14:29:38Z

@bors: retry

bors · 2018-11-24T14:29:44Z

⌛ Trying commit 75071fe with merge e4a81c7...

Add various strcase* functions and getline Adds * `strcasestr` * `strcasecmp` * `strncasecmp` * `getline` I *think* they're semi-universal, but shall see what CI pops up...

bors · 2018-11-24T14:55:51Z

💔 Test failed - status-travis

…cally

palfrey · 2018-11-24T19:20:38Z

b05e058 is a bit of a hack, but I managed to hit (temporarily) one of the Travis issues locally and manually pulling the Docker images before building seemed to fix the problem

alexcrichton · 2018-11-26T19:40:03Z

@bors: r+

bors · 2018-11-26T19:40:03Z

📌 Commit 0942070 has been approved by alexcrichton

palfrey · 2018-11-26T19:44:17Z

Good news: down to just 1 failure ;)
Bad news: Failure on sparc64-unknown-linux-gnu

+ curl -LO https://cdimage.debian.org/cdimage/ports/9.0/sparc64/iso-cd/debian-9.0-sparc64-NETINST-1.iso
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   362  100   362    0     0    456      0 --:--:-- --:--:-- --:--:--   456
  0     0    0     0    0     0      0      0 --:--:--  0:05:01 --:--:--     0
curl: (28) Operation timed out after 300808 milliseconds with 0 out of 0 bytes received

Pretty sure this still isn't due to this PR...

bors · 2018-11-26T19:57:21Z

⌛ Testing commit 0942070 with merge 717d77e...

Add various strcase* functions and getline Adds * `strcasestr` * `strcasecmp` * `strncasecmp` * `getline` I *think* they're semi-universal, but shall see what CI pops up...

bors · 2018-11-26T20:19:07Z

💔 Test failed - status-travis

palfrey · 2018-11-26T23:48:46Z

@bors: retry

bors · 2018-11-26T23:48:46Z

@palfrey: 🔑 Insufficient privileges: not in try users

alexcrichton · 2018-11-27T01:51:47Z

@bors: retry

bors · 2018-11-27T01:51:54Z

⌛ Testing commit 0942070 with merge aee584c...

Add various strcase* functions and getline Adds * `strcasestr` * `strcasecmp` * `strncasecmp` * `getline` I *think* they're semi-universal, but shall see what CI pops up...

bors · 2018-11-27T02:37:51Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing aee584c to master...

gnzlbg · 2018-11-27T09:56:37Z

Thank you!

palfrey added 2 commits November 20, 2018 23:17

Add strcase*

1c4e0de

Add getline

7eed4d0

rust-highfive assigned alexcrichton Nov 20, 2018

palfrey added 2 commits November 20, 2018 23:43

Split out getline and strcasestr to supported platforms

9828bd9

Define _WITH_GETLINE for FreeBSD so we can move getline into general …

9c6714e

…Unix

rust-highfive assigned gnzlbg and unassigned alexcrichton Nov 20, 2018

palfrey added 2 commits November 21, 2018 00:02

Fix missing imports for unix module

b81bb4a

Fix line-length unix style issue

a145cf7

gnzlbg mentioned this pull request Nov 21, 2018

Add SGX C types #1129

Merged

palfrey added 2 commits November 21, 2018 23:55

Merge branch 'master' into strcase-various

d931cd2

Split out strcase* into unix, MSVC and Windows-GNU

08eaa2c

palfrey changed the title ~~[WIP] Add various strcase* functions and getline~~ Add various strcase* functions and getline Nov 21, 2018

palfrey added 3 commits November 23, 2018 21:13

Pull cfg_if! outside the extern

46f08b5

strcase*: Add cloudabi support

b758037

strcase*: add redox support

d75fc9c

palfrey added 2 commits November 23, 2018 22:33

Split out windows strcase* work into gnu/msvc files

cd6b95d

Merge branch 'master' into strcase-various

75071fe

palfrey mentioned this pull request Nov 24, 2018

Docker build issues on Travis #1148

Closed

Download Docker images first as that seems to work better at least lo…

b05e058

…cally

palfrey added 2 commits November 24, 2018 19:27

Remove non-POSIX loop construct

9a04c39

Remove hacky Travis workaround

0942070

bors merged commit 0942070 into rust-lang:master Nov 27, 2018

palfrey deleted the strcase-various branch November 27, 2018 12:29

Conversation

palfrey commented Nov 20, 2018

Uh oh!

rust-highfive commented Nov 20, 2018

Uh oh!

gnzlbg commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

palfrey commented Nov 20, 2018

Uh oh!

gnzlbg commented Nov 20, 2018

Uh oh!

gnzlbg commented Nov 21, 2018

Uh oh!

bors commented Nov 21, 2018

Uh oh!

gnzlbg commented Nov 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Nov 21, 2018

Uh oh!

gnzlbg commented Nov 22, 2018

Uh oh!

palfrey commented Nov 23, 2018

Uh oh!

palfrey commented Nov 23, 2018

Uh oh!

gnzlbg commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

gnzlbg commented Nov 24, 2018

Uh oh!

gnzlbg commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

gnzlbg commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

bors commented Nov 24, 2018

Uh oh!

palfrey commented Nov 24, 2018

Uh oh!

alexcrichton commented Nov 26, 2018

Uh oh!

bors commented Nov 26, 2018

Uh oh!

palfrey commented Nov 26, 2018

Uh oh!

bors commented Nov 26, 2018

Uh oh!

bors commented Nov 26, 2018

Uh oh!

palfrey commented Nov 26, 2018

Uh oh!

bors commented Nov 26, 2018

Uh oh!

alexcrichton commented Nov 27, 2018

Uh oh!

bors commented Nov 27, 2018

Uh oh!

bors commented Nov 27, 2018

Uh oh!

gnzlbg commented Nov 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gnzlbg commented Nov 20, 2018 •

edited

Loading

gnzlbg commented Nov 21, 2018 •

edited

Loading