Repository navigation
Use dl_iterate_phdr on target_os = "qnx" (QNX SDP 8.0) - #789
Conversation
rust-lang/rust#158449 changed the QNX SDP 8.0 targets from target_os = "nto" to "qnx". gimli.rs used dl_iterate_phdr only for "nto", so on SDP 8.0 no libraries were found and every frame was <unknown>. Add "qnx" next to "nto".
|
Be concise. |
|
See the rust-lang/rust LLM usage policy. I intend to remove this as a separate repo, which is why I have not bothered to formally note that I intend for it to be applied here. |
|
@workingjubilee Sorry about that! I’ve rewritten the PR description in my own words. |
workingjubilee
left a comment
There was a problem hiding this comment.
all that text was just for "btw we changed the target name!"?
it's kind of funny. in a way, I don't actually care about all that verification if the code is obviously correct. but I can only tell if the code does what is intended if I can read text that actually describes intent! thus automatic verification and reporting only served to obscure the form of correctness that matters: "is it what we want?"
it is not even worth clicking "Files changed" if I have to sift tea leaves like that.
rust-lang/rust#158449 changed QNX 8.0’s
target_osfrom"nto"to"qnx".src/symbolize/gimli.rsenablesdl_iterate_phdrfor"nto"but not"qnx", leaving every frame as<unknown>. This change adds"qnx"alongside"nto".I tested this on QNX 8.0.0 in QEMU: debug backtraces now include function names and file:line, and
smoke_test_framesandaccuracy, which failed before, now pass.Claude (Opus 5.5), an AI assistant, helped identify, fix, and test this issue while I was developing QNX 8.0.0 tools on macOS. I reviewed the result before posting.