impl TextLen for &'_ Arc<String>

[Matthias-Fauconneau]

Is this intentionally missing ?
Would be nice :)

impl TextLen for &'_ Arc<String> {
    fn text_len(self) -> TextSize {
        use std::ops::Deref;
        self.deref().text_len()
    }
}

TextSize::of:

Types that don't dereference to str but want to be usable in this constructor can implement TextLen.

But the trait is Sealed without a rationale :(

[matklad]

Kind of: we just follow the concervative set of impls of std::Pattern: https://doc.rust-lang.org/stable/std/str/pattern/trait.Pattern.html#implementors

[Matthias-Fauconneau]

Maybe that's a restriction which makes more sense for std though.
But more importantly, this cannot be worked around because of the Sealed :(

[matklad]

Yes, this needs to be fixed at the call-site by calling .as_str(), which doesn't seem like the end of the world to me :)

[CAD97]

That's definitely out-of-date documentation on TextSize::of; I wrote it when we had much more aggressive blanket impls for TextLen.

Our general consensus (for 1.0 at least) was that TextSize::of should be used just for primitives (i.e. what was of_str and of_char in text_unit), and compound types could either provide a primitive conversion (to feed into TextSize::of), or its own ad-hoc accessor.

[CAD97]

we just follow the concervative set of impls of std::Pattern

We should probably add an impl for &[char] then...