Repository navigation
fix(ui): MCP / skill detail as a dialog; delete-from-agent confirm label - #62
Merged
Merged
Conversation
The second confirmation for removing an agent's copy of an MCP server or a skill reused the library-delete label; use the delete-from-agent label. Signed-off-by: mlboy <mlboy@126.com>
Selecting a server or a skill appended its detail after the whole matrix (and, for MCP, after the gateway panel); with many rows it was off-screen and hard to act on. It now opens in a DetailDialog (fixed header with the title and close, scrolling body, Escape / backdrop close, focus trap). The inline confirm bar sticks to the top of the dialog body; Escape dismisses it first. The MCP detail hides while the server edit form is open (one modal at a time). Signed-off-by: mlboy <mlboy@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DetailDialog(fixed header with title + close, scrolling body, Escape / backdrop close, focus trap,noDragRegion). The inline confirm bar sticks to the top of the dialog body; Escape dismisses it first. The MCP detail hides while the edit form is open (one modal at a time).Verification
pnpm test:unit1443 passed; typecheck; DCO.Not verified
Real macOS look and scroll feel with many agents.