Skip to content

size_of_val, min_align_of_val implementation #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mariaKt wants to merge 10 commits into
base: master
Choose a base branch
from
Open

size_of_val, min_align_of_val implementation #1092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
558c0c4
Added intrinsics tests to prove show list.
mariaKt Jun 25, 2026
d1c52ad
Added test for size_of_val (showing it is stuck)
mariaKt Jun 25, 2026
52f39af
size_of_val intrinsic implementation (sized)
mariaKt Jun 25, 2026
942e5a7
Update size_of_val test output
mariaKt Jun 25, 2026
a1b17d1
Added test for min_align_of_val (showing it is stuck)
mariaKt Jun 26, 2026
c6e238c
min_align_of_val intrinsic implementation (sized)
mariaKt Jun 26, 2026
7e5e7d4
Update min_align_of_val test output
mariaKt Jun 26, 2026
4bfd513
Removed intermediate test outputs (there only for PR review)
mariaKt Jun 26, 2026
7340d2c
Update LLVM skip list
mariaKt Jun 26, 2026
ddd1c22
Update Haskell skip list
mariaKt Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions kmir/src/kmir/kdist/mir-semantics/intrinsics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,46 @@ the second argument, so the returned difference is always positive.
[priority(100)]
```

#### Size of a value (`std::intrinsics::size_of_val`)

`size_of_val` returns the size in bytes of the value its argument points to. The pointee type is
computed from the argument's type and its size from the existing `#sizeOf`.

Only statically-sized pointees are handled here: the rule requires the pointee not to be a
dynamically-sized type (`#metadataSize =/=K dynamicSize(1)`). Dynamically-sized pointees (slices,
`str`, `dyn`) need the runtime metadata carried by the fat pointer and are left for later (the
intrinsic stays stuck on them rather than returning a wrong size).

```k
rule <k> #execIntrinsic(IntrinsicFunction(symbol("size_of_val")), ARG:Operand .Operands, DEST, _SPAN)
=> #setLocalValue(DEST, Integer(#sizeOf(TYPESMAP, lookupTy(TYPESMAP, {pointeeTy(lookupTy(TYPESMAP, {#extractOperandType(TYPESMAP, ARG, LOCALS)}:>Ty))}:>Ty)), 64, false))
... </k>
<locals> LOCALS </locals>
<types> TYPESMAP </types>
requires isTy(#extractOperandType(TYPESMAP, ARG, LOCALS))
andBool isTy(pointeeTy(lookupTy(TYPESMAP, {#extractOperandType(TYPESMAP, ARG, LOCALS)}:>Ty)))
andBool #metadataSize(TYPESMAP, pointeeTy(lookupTy(TYPESMAP, {#extractOperandType(TYPESMAP, ARG, LOCALS)}:>Ty))) =/=K dynamicSize(1)

@dkcumming dkcumming Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I thought this was too permissive as it only restricts dynamicSize(1) for all slices. However, looking at rt/types.md the codomain of #metadataSize is { staticSize(N), dynamicSize(1), noMetadataSize }. So in this case, dynamicSize(1) is a sentinel value only.

Not sure if it is worth changing but it would be nice to continue the pattern of using sentinels that are logically distinct from sensible values. I think dynamicSize(-1) would be better here because if one knows that it is impossible immediately by reading it so either there is an error or it is a sentinel only.

[preserves-definedness]
```

#### Minimum alignment of a value (`std::intrinsics::min_align_of_val`)

`min_align_of_val` returns the minimum alignment of the value its argument points to.
The pointee type is computed from the argument's type and the alignment from the existing `#alignOf`. Again only statically-sized pointee types are handled here.
Dynamically-sized ones are left for later, so the intrinsic stays stuck if one reaches here.

```k
rule <k> #execIntrinsic(IntrinsicFunction(symbol("min_align_of_val")), ARG:Operand .Operands, DEST, _SPAN)
=> #setLocalValue(DEST, Integer(#alignOf(TYPESMAP, lookupTy(TYPESMAP, {pointeeTy(lookupTy(TYPESMAP, {#extractOperandType(TYPESMAP, ARG, LOCALS)}:>Ty))}:>Ty)), 64, false))
... </k>
<locals> LOCALS </locals>
<types> TYPESMAP </types>
requires isTy(#extractOperandType(TYPESMAP, ARG, LOCALS))
andBool isTy(pointeeTy(lookupTy(TYPESMAP, {#extractOperandType(TYPESMAP, ARG, LOCALS)}:>Ty)))
andBool #metadataSize(TYPESMAP, pointeeTy(lookupTy(TYPESMAP, {#extractOperandType(TYPESMAP, ARG, LOCALS)}:>Ty))) =/=K dynamicSize(1)
[preserves-definedness]
```

```k
endmodule
```
40 changes: 0 additions & 40 deletions kmir/src/tests/external/data/stable-mir-ui/skip-exec.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,6 @@ tests/ui/catch-unwind-bang.rs
tests/ui/cfg/cfg_attr.rs
tests/ui/cfg/cfg-macros-foo.rs
tests/ui/cfg/cfgs-on-items.rs
tests/ui/cfg/conditional-compile.rs
tests/ui/cfguard-run.rs
tests/ui/char.rs
tests/ui/cleanup-rvalue-for-scope.rs
Expand Down Expand Up @@ -315,7 +314,6 @@ tests/ui/codegen/equal-pointers-unequal/strict-provenance/print.rs
tests/ui/codegen/equal-pointers-unequal/strict-provenance/segfault.rs
tests/ui/codegen/equal-pointers-unequal/strict-provenance/zero.rs
tests/ui/codegen/init-large-type.rs
tests/ui/codegen/issue-16602-3.rs
tests/ui/codegen/issue-27859.rs
tests/ui/codegen/issue-28950.rs
tests/ui/codegen/issue-55976.rs
Expand Down Expand Up @@ -364,8 +362,6 @@ tests/ui/const_prop/const-prop-ice3.rs
tests/ui/const_prop/dont-propagate-generic-instance-2.rs
tests/ui/const_prop/dont-propagate-generic-instance.rs
tests/ui/consts/cast-discriminant-zst-enum.rs
tests/ui/consts/const-adt-align-mismatch.rs
tests/ui/consts/const-big-enum.rs
tests/ui/consts/const-binops.rs
tests/ui/consts/const-block-item-macro-codegen.rs
tests/ui/consts/const-block-item.rs
Expand All @@ -374,22 +370,7 @@ tests/ui/consts/const-bound.rs
tests/ui/consts/const-cast-ptr-int.rs
tests/ui/consts/const-cast.rs
tests/ui/consts/const-contents.rs
tests/ui/consts/const-deref.rs
tests/ui/consts/const_discriminant.rs
tests/ui/consts/const-enum-byref.rs
tests/ui/consts/const-enum-byref-self.rs
tests/ui/consts/const-enum-cast.rs
tests/ui/consts/const-enum-ptr.rs
tests/ui/consts/const-enum-struct2.rs
tests/ui/consts/const-enum-structlike.rs
tests/ui/consts/const-enum-struct.rs
tests/ui/consts/const-enum-tuple2.rs
tests/ui/consts/const-enum-tuple.rs
tests/ui/consts/const-enum-tuplestruct2.rs
tests/ui/consts/const-enum-tuplestruct.rs
tests/ui/consts/const-enum-vec-index.rs
tests/ui/consts/const-enum-vec-ptr.rs
tests/ui/consts/const-enum-vector.rs
tests/ui/consts/const-eval/const_fn_ptr.rs
tests/ui/consts/const-eval/float_methods.rs
tests/ui/consts/const-eval/heap/alloc_intrinsic_nontransient.rs
Expand All @@ -408,9 +389,6 @@ tests/ui/consts/const_in_pattern/custom-eq-branch-pass.rs
tests/ui/consts/const_in_pattern/null-raw-ptr-issue-119270.rs
tests/ui/consts/const-int-arithmetic-overflow.rs
tests/ui/consts/const_let_eq_float.rs
tests/ui/consts/const-needs_drop.rs
tests/ui/consts/const-negative.rs
tests/ui/consts/const-nullary-enum.rs
tests/ui/consts/const-nullary-univariant-enum.rs
tests/ui/consts/const-pattern-variant.rs
tests/ui/consts/const-ptr-nonnull-rpass.rs
Expand All @@ -422,7 +400,6 @@ tests/ui/consts/const-region-ptrs.rs
tests/ui/consts/const.rs
tests/ui/consts/const-size_of_val-align_of_val.rs
tests/ui/consts/const-struct.rs
tests/ui/consts/const-tuple-struct.rs
tests/ui/consts/const-typeid-of-rpass.rs
tests/ui/consts/const-variant-count.rs
tests/ui/consts/const-vec-of-fns.rs
Expand All @@ -434,17 +411,14 @@ tests/ui/consts/issue-21721.rs
tests/ui/consts/issue-23833.rs
tests/ui/consts/issue-27890.rs
tests/ui/consts/issue-33537.rs
tests/ui/consts/issue-37222.rs
tests/ui/consts/issue-46553.rs
tests/ui/consts/issue-58435-ice-with-assoc-const.rs
tests/ui/consts/issue-66345.rs
tests/ui/consts/issue-67640.rs
tests/ui/consts/issue-69532.rs
tests/ui/consts/issue-90762.rs
tests/ui/consts/load-preserves-partial-init.rs
tests/ui/consts/locals-in-const-fn.rs
tests/ui/consts/mut-ptr-to-static.rs
tests/ui/consts/offset.rs
tests/ui/consts/promoted_const_call4.rs
tests/ui/consts/promotion-mutable-ref.rs
tests/ui/consts/references.rs
Expand Down Expand Up @@ -773,7 +747,6 @@ tests/ui/issues/issue-12677.rs
tests/ui/issues/issue-12744.rs
tests/ui/issues/issue-12860.rs
tests/ui/issues/issue-12909.rs
tests/ui/issues/issue-13027.rs
tests/ui/issues/issue-13204.rs
tests/ui/issues/issue-13323.rs
tests/ui/issues/issue-13434.rs
Expand Down Expand Up @@ -849,7 +822,6 @@ tests/ui/issues/issue-23891.rs
tests/ui/issues/issue-24533.rs
tests/ui/issues/issue-24779.rs
tests/ui/issues/issue-25089.rs
tests/ui/issues/issue-25145.rs
tests/ui/issues/issue-25497.rs
tests/ui/issues/issue-25515.rs
tests/ui/issues/issue-25549-multiple-drop.rs
Expand All @@ -872,7 +844,6 @@ tests/ui/issues/issue-28498-ugeh-ex1.rs
tests/ui/issues/issue-28550.rs
tests/ui/issues/issue-29053.rs
tests/ui/issues/issue-29071-2.rs
tests/ui/issues/issue-29147-rpass.rs
tests/ui/issues/issue-2935.rs
tests/ui/issues/issue-29466.rs
tests/ui/issues/issue-29668.rs
Expand Down Expand Up @@ -1066,7 +1037,6 @@ tests/ui/match/issue-114691.rs
tests/ui/match/issue-115681.rs
tests/ui/match/issue-11940.rs
tests/ui/match/issue-26251.rs
tests/ui/match/issue-36401.rs
tests/ui/match/issue-42679.rs
tests/ui/match/issue-72680.rs
tests/ui/match/match-float.rs
Expand Down Expand Up @@ -1113,7 +1083,6 @@ tests/ui/mir/mir_overflow_off.rs
tests/ui/mir/mir_raw_fat_ptr.rs
tests/ui/mir/mir_temp_promotions.rs
tests/ui/mir/validate/needs-reveal-all.rs
tests/ui/monomorphize-abi-alignment.rs
tests/ui/moves/move-1-unique.rs
tests/ui/moves/move-2.rs
tests/ui/moves/move-2-unique.rs
Expand Down Expand Up @@ -1168,7 +1137,6 @@ tests/ui/numbers-arithmetic/overflow-attribute-works-2.rs
tests/ui/numbers-arithmetic/saturating-float-casts.rs
tests/ui/numbers-arithmetic/saturating-float-casts-wasm.rs
tests/ui/numbers-arithmetic/shift-near-oflo.rs
tests/ui/numbers-arithmetic/shift.rs
tests/ui/numbers-arithmetic/u128-as-f32.rs
tests/ui/numbers-arithmetic/u128.rs
tests/ui/numbers-arithmetic/unary-minus-suffix-inference.rs
Expand Down Expand Up @@ -1301,7 +1269,6 @@ tests/ui/regions/regions-self-in-enums.rs
tests/ui/regions/regions-simple.rs
tests/ui/regions/regions-static-closure.rs
tests/ui/regions/regions-trait-object-1.rs
tests/ui/repeat-expr/repeat-expr-in-static.rs
tests/ui/repr/aligned_enum_cast.rs
tests/ui/repr/repr_c_int_align.rs
tests/ui/resolve/blind-item-local-shadow.rs
Expand Down Expand Up @@ -1385,7 +1352,6 @@ tests/ui/self/string-self-append.rs
tests/ui/self/ufcs-explicit-self.rs
tests/ui/self/uniq-self-in-mut-slot.rs
tests/ui/self/where-for-self.rs
tests/ui/sepcomp/sepcomp-statics.rs
tests/ui/sepcomp/sepcomp-unwind.rs
tests/ui/simd/array-type.rs
tests/ui/simd/generics.rs
Expand Down Expand Up @@ -1425,9 +1391,7 @@ tests/ui/specialization/specialization-assoc-fns.rs
tests/ui/specialization/specialization-basics.rs
tests/ui/specialization/specialization-default-methods.rs
tests/ui/sse2.rs
tests/ui/static/refer-to-other-statics-by-value.rs
tests/ui/statics/const_generics.rs
tests/ui/statics/issue-17233.rs
tests/ui/statics/static-function-pointer.rs
tests/ui/statics/static-impl.rs
tests/ui/statics/static-promotion.rs
Expand All @@ -1450,7 +1414,6 @@ tests/ui/structs-enums/class-impl-very-parameterized-trait.rs
tests/ui/structs-enums/class-poly-methods.rs
tests/ui/structs-enums/class-separate-impl.rs
tests/ui/structs-enums/class-str-field.rs
tests/ui/structs-enums/codegen-tag-static-padding.rs
tests/ui/structs-enums/empty-tag.rs
tests/ui/structs-enums/enum-alignment.rs
tests/ui/structs-enums/enum-clike-ffi-as-int.rs
Expand All @@ -1460,7 +1423,6 @@ tests/ui/structs-enums/enum-disr-val-pretty.rs
tests/ui/structs-enums/enum-non-c-like-repr-c-and-int.rs
tests/ui/structs-enums/enum-non-c-like-repr-c.rs
tests/ui/structs-enums/enum-non-c-like-repr-int.rs
tests/ui/structs-enums/enum-nullable-const-null-with-fields.rs
tests/ui/structs-enums/enum-nullable-simplifycfg-misopt.rs
tests/ui/structs-enums/enum-null-pointer-opt.rs
tests/ui/structs-enums/enum-univariant-repr.rs
Expand Down Expand Up @@ -1599,7 +1561,6 @@ tests/ui/traits/issue-9394-inherited-calls.rs
tests/ui/traits/kindck-owned-contains-1.rs
tests/ui/traits/monad.rs
tests/ui/traits/multidispatch-conditional-impl-not-considered.rs
tests/ui/traits/next-solver/alias-bound-preference.rs
tests/ui/traits/next-solver/dyn-any-dont-prefer-impl.rs
tests/ui/traits/object/auto-dedup.rs
tests/ui/traits/object/exclusion.rs
Expand Down Expand Up @@ -1678,7 +1639,6 @@ tests/ui/unboxed-closures/unboxed-closures-prelude.rs
tests/ui/unboxed-closures/unboxed-closures-single-word-env.rs
tests/ui/unboxed-closures/unboxed-closures-sugar-object.rs
tests/ui/unboxed-closures/unboxed-closures-zero-args.rs
tests/ui/union/union-align.rs
tests/ui/union/union-const-codegen.rs
tests/ui/union/union-const-eval-field.rs
tests/ui/union/union-drop-assign.rs
Expand Down
Loading
Loading