Skip to content

chore(main): release 0.25.4 - #501

Open
github-actions[bot] wants to merge 3 commits into
mainfrom
release-please--branches--main
Open

github-actions[bot] wants to merge 3 commits into
mainfrom
release-please--branches--main

Conversation

@github-actions

@github-actions github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🤖 I have created a release beep boop

0.25.4 (2026-10-09)

  • api: cover skillsSharedWith in the targets list (eabe5fb)

New Features

  • api: list the targets that share a target's skills folder (06b37d0)
  • sync: add target_naming: prefixed for copy-mode targets (8a952a0)
  • sync: add target_naming: prefixed for copy-mode targets (35f3bb0)
  • sync: make prefixed target naming misconfigurations visible (#503) (b0d87fb)
  • target: offer prefixed naming in the CLI, dashboard and schemas (226c5c9)
  • ui: show prefixed naming disabled outside copy mode (3d55f4c)
  • ui: show which settings differ in the Sync page folder conflict (c7905de)
  • ui: warn on the target page when settings clash with a shared folder (5f81209)
  • utils: add a line-based frontmatter string setter (a9c3189)

Bug Fixes

  • collect,install: collect only real skills; let --track take a local git path (#508) (2ce4683)
  • config: keep agents-only projects valid under prefixed naming (dd8d03f)
  • config: reject prefixed naming on a managed project in raw configs (6e328b0)
  • config: reject prefixed naming on non-copy projects entries (9ed8272)
  • config: skip the naming-mode check for targets with skills off (0782395)
  • config: validate a project target against the inherited naming (0b496c9)
  • diff: report a copy recorded under another naming as modified (2ff8bde)
  • diff: report a target naming migration as a rename (0477f1e)
  • frontmatter: read and rewrite SKILL.md that starts with a UTF-8 BOM (#505) (9c994fa)
  • server: check unexpanded projects before changing the global mode (e1889e4)
  • server: refuse a global mode that breaks inherited prefixed naming (92f3d80)
  • sync: add a missing name before the first frontmatter key (4c43328)
  • sync: add the prefixed name before a YAML document end marker (5cf18e2)
  • sync: close gaps found while simulating the prefixed naming switch (#504) (ec2a8ab)
  • sync: credit target naming for isolated duplicate names (e610006)
  • sync: decode the whole block when the name line is not a string (4e850e5)
  • sync: decode the whole frontmatter when no plain name line is found (ca38177)
  • sync: drop a copy whose prefixed name could not be written (096de1a)
  • sync: find a document end marker followed by a comment (967e1fa)
  • sync: flag shared skills folders whose mode or naming differ (5e3840e)
  • sync: flag shared skills folders whose mode or naming differ (366fb23), closes #498
  • sync: ignore target naming for symlink targets sharing a folder (588d29c)
  • sync: keep naming migration from claiming another skill's entry (1e00939)
  • sync: keep the indent of an indented root mapping when renaming (adf375d)
  • sync: keep the name's YAML anchor when prefixing it (183beeb)
  • sync: keep Unicode letters and digits in the repo prefix (7febeb9)
  • sync: read a block-scalar skill name (04dacce)
  • sync: read a skill's name from any valid YAML key form (c95e385)
  • sync: replace copy-mode copies with links when switching back to merge (#506) (c638b46)
  • sync: replace the whole name entry when prefixing a copied skill (330b345)
  • sync: report collisions that only a target's naming creates (33892c2)
  • sync: resolve a skill name given as a YAML alias (fae3439)
  • sync: resolve a skill name inherited through a YAML merge key (65f468c)
  • sync: rewrite only the name value, keeping its key as written (666df43)
  • sync: rewrite the name inside flow-style frontmatter (84cccb0)
  • sync: rewrite the prefixed name of a read-only SKILL.md (c0d2d04)
  • target: add global targets in copy mode when they would inherit prefixed (a9e3613)
  • target: add project targets in copy mode under prefixed naming (7b67650)
  • target: check prefixed naming when turning skills back on (86ff94f)
  • target: describe prefixed in the TUI naming picker (73a3c51)
  • ui: refresh instruction queries after target changes (b6b5130)
  • ui: warn on the target page when only the shared filters differ (dd3cc06)

This PR was generated with Release Please. See documentation.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T17:59:39.003370Z d888cb7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b251cbe1a4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -1,3 +1,3 @@
{
".": "0.25.3"
".": "0.25.4"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Release these features as 0.26.0

This release contains three feat entries, but the manifest advances only from 0.25.3 to 0.25.4. With bump-minor-pre-major: true and bump-patch-for-minor-pre-major: false, merging this would make the release workflow tag a feature release as a patch; update the manifest and changelog heading to 0.26.0 before the tag is created.

AGENTS.md reference: AGENTS.md:L48-L48

Useful? React with 👍 / 👎.

@github-actions
github-actions Bot force-pushed the release-please--branches--main branch 5 times, most recently from fc962db to e3cd47c Compare October 9, 2026 17:07
@runkids

runkids commented Oct 9, 2026

Copy link
Copy Markdown
Owner

@codex review — please check the hand-written 0.25.4 entry in CHANGELOG.md against the commits in v0.25.3..main: wrong or misleading claims, flags/strings that do not exist, Bug Fixes that only fix code added in this range, and user-visible changes left out.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4fe68fd443

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md Outdated

#### Sync

- **Prefixed target naming for skills from tracked repos** — `target_naming: prefixed` names each skill inside a tracked repo `<repo>-<name>`, in the copied folder and in the copy's `name:`, so same-named skills from different repos (for example two `prototype` skills) both reach the tool instead of being skipped as a collision under `standard`. Local skills keep their standard name, and the source is never changed. It works in copy mode only. Refs: #497.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge State the already-prefixed-name exception

For a tracked repo such as _bmad containing a skill named bmad-ux, this says every skill becomes <repo>-<name> and therefore implies bmad-bmad-ux; however, PrefixedTargetName deliberately leaves names equal to the repo name or already starting with repo- unchanged. The detailed sync documentation describes this exception, so include it here to avoid misleading users about the target folder and copied name: they will receive.

AGENTS.md reference: AGENTS.md:L13-L15

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 78a9e70: the bullet now says a name that already starts with the repo name is not prefixed again (_bmad/skills/bmad-ux stays bmad-ux), matching PrefixedTargetName in internal/sync/target_naming.go.

Comment thread CHANGELOG.md
Comment on lines +19 to +21
#### Dashboard

- **Shared skills folder conflicts are shown where you change them** — when another target writes the same skills folder, the target page warns under the mode, naming or filter control whose change would make the two syncs undo each other, and offers to use the other target's value. The Sync page's folder conflict notice now lists which settings differ, with a link to the target page.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the post-0.25.3 dashboard polish

In the inspected release range, d17907e changes ui/src/pages/ResourcesPage.tsx to remove the roughly 60px gap around the Skills toolbar and changes ui/src/components/hub/HubView.tsx so the Hub header gains the shared pinned-bar treatment. That commit is after the 0.25.3 release commit (fde6098), yet this 0.25.4 Dashboard section omits both changes; the older 0.25.3 entry even attributes the Skills-page behavior to the previous version. Add or move the dashboard note so the release history assigns these shipped UI changes to 0.25.4.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 78a9e70: added a Dashboard bullet for d17907e (Skills toolbar no longer ~60px below the tabs; Hub header pins with padding and a bottom line). The 0.25.3 entry describes the sticky toolbar that shipped then, so it is left as is.

@runkids

runkids commented Oct 9, 2026

Copy link
Copy Markdown
Owner

@codex review (head 78a9e70)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78a9e70dd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md Outdated
#### Sync

- **Targets sharing a skills folder with a different mode or naming are reported** — only `include` and `exclude` were compared, so two targets that undid each other on every sync got the generic shared-folder hint. `sync` and `doctor` now warn that their settings differ. Naming is not compared when both targets use `symlink` mode, which ignores it. Refs: #498.
- **Switching a target from copy back to merge replaces its copies with links** — the copies stayed real folders, so `status` and `doctor` kept saying "run skillshare sync" while sync changed nothing until `sync --force`. Merge sync now replaces copies that copy mode made and that were not edited since; edited copies and folders you made yourself are still kept until `sync --force`. `diff` and the dashboard Sync page say which copies will be replaced by a link.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify edited-copy preservation during naming changes

When a prefixed copy target is switched to merge, its naming must also change to flat or standard; for repo skills whose target names consequently change, merge creates the new link and pruning removes the old manifest-managed directory even if that copy was edited. The existing sync-modes documentation explicitly records this exception and notes that only the backup retains the old copy, so the unconditional promise that edited copies remain until sync --force is misleading and should qualify same-sync naming changes.

AGENTS.md reference: AGENTS.md:L15-L15

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c44570b: the bullet now says that when the same sync also changes target_naming (as leaving prefixed does), a renamed copy is removed even if edited and the backup of a plain sync keeps it, matching website/docs/understand/sync-modes.md.

@runkids

runkids commented Oct 9, 2026

Copy link
Copy Markdown
Owner

@codex review (head c44570b)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c44570b057

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md Outdated
skillshare sync
```
- Switching between `flat`, `standard` and `prefixed` renames managed entries in place, and copies are copied again so their `name:` matches the new naming. If a local skill already holds the new name, the skill stays under its old entry, and `diff` reports that folder as `Local only, skill kept under old name`.
- A target that resolves to `prefixed` outside copy mode fails validation; `status`, `doctor` and `target list` flag it before you sync, and `target list --json` adds a `warning` field. `target add` gives a new target copy mode when it would inherit `prefixed`, and says so.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Qualify target list coverage for managed projects

For an invalid target expanded from a global projects: entry, neither target list nor target list --json flags it: targetList calls config.LoadWithoutProjects() (cmd/skillshare/target.go), which explicitly removes expanded project targets (internal/config/projects.go). Only status and doctor cover that case, and the detailed sync documentation already limits the target list guarantee to targets declared under targets:. Qualify this sentence accordingly so users do not expect a diagnostic that the command cannot show.

AGENTS.md reference: AGENTS.md:L15-L15

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in d888cb7: the bullet now says status, doctor and, for the targets in targets:, target list flag it, matching website/docs/understand/sync-modes.md. (The Release PR was regenerated by b6b5130; d888cb7 restores the curated entry with this change.)

@github-actions
github-actions Bot force-pushed the release-please--branches--main branch from c44570b to a24d588 Compare October 9, 2026 17:55
github-actions Bot and others added 2 commits October 9, 2026 17:55
b6b5130 regenerated the Release PR and replaced the curated entry with the
commit list. Restore it (as of c44570b), add the instruction-query
dashboard fix from b6b5130, and say target list flags only the targets in
`targets:`, not those expanded from `projects:`.
@runkids

runkids commented Oct 9, 2026

Copy link
Copy Markdown
Owner

@codex review (head d888cb7)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: d888cb7d5d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(sync): targets sharing a skills folder with different naming or mode aren't reported as a conflict

1 participant