Repository navigation
chore(main): release 0.25.4 - #501
github-actions[bot] wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b251cbe1a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,3 +1,3 @@ | |||
| { | |||
| ".": "0.25.3" | |||
| ".": "0.25.4" | |||
There was a problem hiding this comment.
Release these features as 0.26.0
This release contains three feat entries, but the manifest advances only from 0.25.3 to 0.25.4. With bump-minor-pre-major: true and bump-patch-for-minor-pre-major: false, merging this would make the release workflow tag a feature release as a patch; update the manifest and changelog heading to 0.26.0 before the tag is created.
AGENTS.md reference: AGENTS.md:L48-L48
Useful? React with 👍 / 👎.
fc962db to
e3cd47c
Compare
|
@codex review — please check the hand-written 0.25.4 entry in CHANGELOG.md against the commits in v0.25.3..main: wrong or misleading claims, flags/strings that do not exist, Bug Fixes that only fix code added in this range, and user-visible changes left out. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fe68fd443
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| #### Sync | ||
|
|
||
| - **Prefixed target naming for skills from tracked repos** — `target_naming: prefixed` names each skill inside a tracked repo `<repo>-<name>`, in the copied folder and in the copy's `name:`, so same-named skills from different repos (for example two `prototype` skills) both reach the tool instead of being skipped as a collision under `standard`. Local skills keep their standard name, and the source is never changed. It works in copy mode only. Refs: #497. |
There was a problem hiding this comment.
State the already-prefixed-name exception
For a tracked repo such as _bmad containing a skill named bmad-ux, this says every skill becomes <repo>-<name> and therefore implies bmad-bmad-ux; however, PrefixedTargetName deliberately leaves names equal to the repo name or already starting with repo- unchanged. The detailed sync documentation describes this exception, so include it here to avoid misleading users about the target folder and copied name: they will receive.
AGENTS.md reference: AGENTS.md:L13-L15
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 78a9e70: the bullet now says a name that already starts with the repo name is not prefixed again (_bmad/skills/bmad-ux stays bmad-ux), matching PrefixedTargetName in internal/sync/target_naming.go.
| #### Dashboard | ||
|
|
||
| - **Shared skills folder conflicts are shown where you change them** — when another target writes the same skills folder, the target page warns under the mode, naming or filter control whose change would make the two syncs undo each other, and offers to use the other target's value. The Sync page's folder conflict notice now lists which settings differ, with a link to the target page. |
There was a problem hiding this comment.
Include the post-0.25.3 dashboard polish
In the inspected release range, d17907e changes ui/src/pages/ResourcesPage.tsx to remove the roughly 60px gap around the Skills toolbar and changes ui/src/components/hub/HubView.tsx so the Hub header gains the shared pinned-bar treatment. That commit is after the 0.25.3 release commit (fde6098), yet this 0.25.4 Dashboard section omits both changes; the older 0.25.3 entry even attributes the Skills-page behavior to the previous version. Add or move the dashboard note so the release history assigns these shipped UI changes to 0.25.4.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78a9e70dd4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #### Sync | ||
|
|
||
| - **Targets sharing a skills folder with a different mode or naming are reported** — only `include` and `exclude` were compared, so two targets that undid each other on every sync got the generic shared-folder hint. `sync` and `doctor` now warn that their settings differ. Naming is not compared when both targets use `symlink` mode, which ignores it. Refs: #498. | ||
| - **Switching a target from copy back to merge replaces its copies with links** — the copies stayed real folders, so `status` and `doctor` kept saying "run skillshare sync" while sync changed nothing until `sync --force`. Merge sync now replaces copies that copy mode made and that were not edited since; edited copies and folders you made yourself are still kept until `sync --force`. `diff` and the dashboard Sync page say which copies will be replaced by a link. |
There was a problem hiding this comment.
Qualify edited-copy preservation during naming changes
When a prefixed copy target is switched to merge, its naming must also change to flat or standard; for repo skills whose target names consequently change, merge creates the new link and pruning removes the old manifest-managed directory even if that copy was edited. The existing sync-modes documentation explicitly records this exception and notes that only the backup retains the old copy, so the unconditional promise that edited copies remain until sync --force is misleading and should qualify same-sync naming changes.
AGENTS.md reference: AGENTS.md:L15-L15
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in c44570b: the bullet now says that when the same sync also changes target_naming (as leaving prefixed does), a renamed copy is removed even if edited and the backup of a plain sync keeps it, matching website/docs/understand/sync-modes.md.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c44570b057
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| skillshare sync | ||
| ``` | ||
| - Switching between `flat`, `standard` and `prefixed` renames managed entries in place, and copies are copied again so their `name:` matches the new naming. If a local skill already holds the new name, the skill stays under its old entry, and `diff` reports that folder as `Local only, skill kept under old name`. | ||
| - A target that resolves to `prefixed` outside copy mode fails validation; `status`, `doctor` and `target list` flag it before you sync, and `target list --json` adds a `warning` field. `target add` gives a new target copy mode when it would inherit `prefixed`, and says so. |
There was a problem hiding this comment.
Qualify target list coverage for managed projects
For an invalid target expanded from a global projects: entry, neither target list nor target list --json flags it: targetList calls config.LoadWithoutProjects() (cmd/skillshare/target.go), which explicitly removes expanded project targets (internal/config/projects.go). Only status and doctor cover that case, and the detailed sync documentation already limits the target list guarantee to targets declared under targets:. Qualify this sentence accordingly so users do not expect a diagnostic that the command cannot show.
AGENTS.md reference: AGENTS.md:L15-L15
Useful? React with 👍 / 👎.
c44570b to
a24d588
Compare
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🤖 I have created a release beep boop
0.25.4 (2026-10-09)
New Features
Bug Fixes
This PR was generated with Release Please. See documentation.