Conversation
set_address handed nil to show, update and destroy when the person had no address yet, so each of them raised (nil partial, nil.update, nil.destroy!) and answered 500. Raising RecordNotFound there turns all three into the 404 they should be. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
AddressesController#set_addresshandedniltoshow,updateanddestroywhen the person had no address yet, so each of them raised (nil partial,nil.update,nil.destroy!) and answered 500. RaisingActiveRecord::RecordNotFoundthere turns all three into the 404 they should be.Issue
No open issue; found while poking at the person pages. Happy to open one if you prefer tracking it that way.
Testing
Controller tests for
show,updateanddestroyon a person without an address, asserting 404. All three fail with a 500 without the change.Ran
bin/rails test(132 runs, 0 failures) andbin/rubocopclean.Written with help from Claude Code; I reviewed and ran everything myself.
🤖 Generated with Claude Code