Fix BotFilter to restore types when base exits bot-only state#424
Merged
Fix BotFilter to restore types when base exits bot-only state#424
Conversation
When a BotFilter's base_vtx transitions from bot-only to having non-bot types, previously suppressed variable types were not restored. This caused variables assigned inside begin/rescue blocks to lose their types when the rescue clause contained raise (bot). The fix adds type restoration in on_type_added when the base_vtx is no longer bot-only. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a BotFilter's base_vtx transitions from bot-only to having non-bot types, previously suppressed variable types were not restored. This caused variables assigned inside begin/rescue blocks to lose their types when the rescue clause contained raise (bot).
The fix adds type restoration in on_type_added when the base_vtx is no longer bot-only.