Support previews for stacked pull requests - #1807
Open
st0012 wants to merge 3 commits into
Open
Conversation
Documentation previewCommit: |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The PR candidate lookup must include the full branch-wide result to avoid missing deployments and comments.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Extends documentation previews to stacked PRs and non-default base branches.
Changes:
- Rebuilds previews after base retargeting.
- Resolves and deploys previews per matching PR.
- Revalidates PR heads and bases before deployment.
File summaries
| File | Review |
|---|---|
.github/workflows/pr-preview-check.yml |
Updates triggers and concurrency behavior. |
.github/workflows/cloudflare-preview.yml |
Adds multi-PR deployment, but its fallback-only branch lookup can miss PRs when run.pull_requests is incomplete. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -66,7 +63,6 @@ jobs: | |||
| repo: context.repo.repo, | |||
| state: 'open', | |||
| head: `${headOwner}:${headBranch}`, | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports documentation previews for pull requests targeting any branch in
ruby/rdoc, including stacked PRs. Previews remain automatic, with no maintainer deployment approval.Fork workflow events can omit the PR number. The resolver finds each open PR with the same source repository, branch, and head commit. If one head branch targets multiple bases, each PR gets its own preview URL and comment. Each deployment checks that PR's head and base again. Cloudflare secrets remain limited to the deployment step, and the trusted workflow does not check out PR code.
Base retargets start a new preview build. Title and body edits skip the build without cancelling active work or causing missing-artifact errors. A successful build that actually ran must still provide a valid artifact.
The preview uses the exact PR head, not a merge with its base branch. A parent branch update therefore does not rebuild the child preview. Restacking the child starts a new build through the
synchronizeevent.