Keep selected Aliki search result visible - #1805
Merged
tompng merged 1 commit intoSep 7, 2026
Merged
Conversation
st0012
requested a deployment
to
fork-preview-protection
August 31, 2026 18:25 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
st0012
force-pushed
the
codex/unify-aliki-search
branch
from
August 31, 2026 18:36
4e29cdc to
671dc73
Compare
st0012
force-pushed
the
codex/keep-aliki-search-selection-visible
branch
from
August 31, 2026 18:38
28d7cef to
09523fb
Compare
st0012
requested a deployment
to
fork-preview-protection
August 31, 2026 18:38 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
st0012
force-pushed
the
codex/keep-aliki-search-selection-visible
branch
from
September 1, 2026 10:42
09523fb to
471fd7b
Compare
st0012
force-pushed
the
codex/unify-aliki-search
branch
from
September 1, 2026 12:24
671dc73 to
dcf0379
Compare
st0012
force-pushed
the
codex/keep-aliki-search-selection-visible
branch
from
September 6, 2026 13:03
471fd7b to
24a0780
Compare
st0012
marked this pull request as ready for review
September 6, 2026 13:04
st0012
force-pushed
the
codex/keep-aliki-search-selection-visible
branch
from
September 6, 2026 13:05
24a0780 to
9018ad6
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Relative positioning retains the desktop top offset, potentially moving compact results outside the clipped viewport.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Keeps keyboard-selected Aliki search results visible in compact layouts.
Changes:
- Makes the search body a constrained flex container.
- Moves vertical scrolling to the result list.
File summaries
| File | Description |
|---|---|
lib/rdoc/generator/template/aliki/css/rdoc.css |
Updates compact search scrolling behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Documentation previewCommit: |
tompng
reviewed
Sep 6, 2026
st0012
force-pushed
the
codex/keep-aliki-search-selection-visible
branch
from
September 6, 2026 23:20
9018ad6 to
ab52458
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Relative positioning unintentionally activates the existing vertical offset and can shift or clip results.
Review details
Suppressed comments (1)
lib/rdoc/generator/template/aliki/css/rdoc.css:2137
- The base
#search-resultsrule still setstop: calc(100% + var(--space-2)). Changing this element fromstatictorelativemakes that offset apply in the compact layout, shifting the list downward (and potentially clipping it inside the overflow-hidden body). Resettopwhile retaining relative positioning for the navigation offset calculations.
position: relative;
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On compact layouts, the search body owned scrolling while keyboard navigation continued to scroll the result list. Arrow-key selection moved, but the selected row could leave the visible panel.
Keep the result list as the scroll container in the compact layout, matching desktop. The existing search navigation now keeps the selected row visible without breakpoint-specific JavaScript or moving the page.