Repository navigation
Align the ActiveRecord example documentation and CI - #17
Merged
Merged
Conversation
Carry the master compatibility matrix, coverage, lint, and Rack compliance fixes to the PostgreSQL branch. Add a health-checked PostgreSQL 17 service and migration setup, preserve integer IDs and page/size pagination, and verify persisted JSON writes. Correct standalone ActiveRecord configuration and migration versioning. Remove accessors shadowing database columns so API writes persist as intended. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the active ActiveRecord example with the master baseline merged in #16. Shared CI differs only in its target branch, a health-checked PostgreSQL 17 service/test URL, and database creation/migrations before tests. Keep the same five Ruby 3.3/3.4/4.0, Grape 2/3/4, and Rack 2/3 combinations, separate lint, and parallel Coveralls reporting.
Carry shared HTTPS dependencies, JSON compatibility, deterministic requires, Rack-compliant HAL redirects/static fallback, and root-route coverage. Add Puma for the documented startup and refresh the PostgreSQL bundle. Align README structure, branch-specific badges, JSON examples, development/coverage instructions, and the table of all three active examples.
Keep PostgreSQL persistence, integer IDs, and page/size pagination. Necessary ActiveRecord-specific fixes are limited to passing the full environment configuration to database tasks, selecting the configured environment for connections, supporting DATABASE_URL in development, versioning the migration to match the existing 8.0 schema semantics, and removing Ruby accessors that shadow persisted columns. New JSON request coverage reloads records from the database, checking both supported media types and boolean values.
Locally verified all 30 examples and RuboCop against an isolated PostgreSQL instance, plus fresh database creation, the original migration itself (not just schema loading), and actionlint. No lint limits or exclusions are raised. Hosted PostgreSQL 17 matrix verification will be recorded below.
Targets with-activerecord. No existing database instances or other local checkouts are modified.
AI-authored on behalf of @dblock.
Hosted verification for
b3e7b42f10223c4138fc790fa06bbedee28b9c58: all five PostgreSQL 17 compatibility jobs and Coveralls finalization and RuboCop pass. Also verified the documented development initialization/Puma command and persisted POST/PUT/GET round trip over real HTTP.