Repository navigation
Replace deprecated Tilt cache with a synchronized Hash - #55
Merged
Merged
Conversation
Danger ReportNo issues found. |
|
coverage: 100.0%. remained the same — dblock:fix/tilt-cache-51 into ruby-grape:master |
dblock
force-pushed
the
fix/tilt-cache-51
branch
from
October 26, 2026 13:39
3d18afc to
80fc7cf
Compare
Keep compiled template and missing-layout memoization without Tilt::Cache. Serialize cache population across concurrent requests and retain existing format-specific cache keys. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
fix/tilt-cache-51
branch
from
October 26, 2026 13:41
80fc7cf to
43ac827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace Tilt::Cache with a plain Hash and mutex-protected cache population, keeping template/layout memoization and existing root/format-specific keys.
Preserve cached nil results for missing layouts and prevent duplicate template compilation under concurrent requests.
Add focused cases with Tilt::Cache hidden, covering template reuse, missing layouts, and concurrent population; retain existing template/layout/format cache request tests.
Fix Danger checks by normalizing changelog release headings, adding a README table of contents, and converting README line endings to LF.
Validation
All 34 examples and RuboCop pass locally on Ruby 4.0/Grape 4. No new dependencies or lint exclusions.
CI: Ruby matrix and lint.
Closes #51.
Created by Copilot, an AI, on behalf of @dblock.