Repository navigation
Conversation
Update hooks/opencode/rtk.ts to support both OpenCode 1.0 and OpenCode 2.0 plugin interfaces. - Add default export with id and setup for OpenCode 2.0 plugin loader - Register execute.before and create.before hooks for shell commands - Retain RtkOpenCodePlugin named export and server property for OpenCode 1.0 backward compatibility - Use node:child_process execFile to invoke rtk rewrite cleanly - Add unit test verifying dual compatibility in src/hooks/init.rs - Update hooks/README.md documentation
4 tasks done
|
Thank you for this clean fix, any eta to merge this? |
Same question. |
Author
|
Hi @KuSh , do you have time to review this PR? A few users have asked about its merge status. Please let me know if you need any changes from me. Thanks! |
2 tasks done
Author
|
I am closing this PR in favor of #4187. #4187 now covers the OpenCode 2.0 compatibility issue more completely, including exit code 3 handling, Windows support, binary resolution, and runtime tests. Thanks to everyone who tested and followed up on this issue. Further work on this issue will be tracked in #4187. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hooks/opencode/rtk.tsvia default export{ id, setup }, hookingexecute.before(tool) andcreate.before(shell).RtkOpenCodePluginnamed export andserverproperty.node:child_processexecFileto eliminate dependency on$shell interpolation and prevent shell injection.Test plan
cargo fmt --all && cargo clippy --all-targets && cargo testtest_opencode_plugin_dual_compatibility_v1_and_v2unit test insrc/hooks/init.rs