Repository navigation
fix: align OpenCode and OpenClaw TypeScript plugins with Pi contract - #2426
Closed
Andrei-hub11 wants to merge 1 commit into
Closed
Andrei-hub11 wants to merge 1 commit into
Andrei-hub11 wants to merge 1 commit into
Conversation
|
|
Andrei-hub11
force-pushed
the
fix/hooks-ts-rewrite-contract-parity
branch
from
June 13, 2026 03:01
7db73eb to
9fc714b
Compare
4 tasks done
Contributor
|
This pull request has been automatically marked as stale due to 90 days of inactivity. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. Your contribution is very much appreciated — we're sorry we haven't been able to review it yet. |
Author
|
bump |
Collaborator
|
Thank you for the careful write-up. Closing as outdated because of OpenCode v2, which the plugin code this PR edits no longer fits. The findings here are still useful for the OpenCode plugin work in #4187: probing with |
amnesiaof
added a commit
to amnesiaof/rtk
that referenced
this pull request
Oct 5, 2026
…51.1 KuSh's review of rtk-ai#2426 named two gaps that also apply here: the plugin decided usability from the file's existence, and set no minimum version. existsSync only proves a file is there. A wrong-arch binary, a broken install, or a stale RTK_BIN all pass that check and then fail on every single tool call. Spawning `rtk --version` once per session is the check that actually means something, and the answer is cached per binary. The floor is 0.51.1, not 0.51.0: `rtk hook opencode` was added in rtk-ai#4349 and exists in no released version -- v0.51.0's src/main.rs has no HookCommands::Opencode variant. Without the gate a 0.51.0 user gets a plugin that registers hooks, delegates to a missing subcommand, and silently passes every command through. A develop build reports 0.49.0 because release-please only bumps Cargo.toml on master, and the warning it gets is accurate: such a build has no release version. An unparseable banner is not evidence of an old rtk, so it passes and the delegation call still fails open.
amnesiaof
added a commit
to amnesiaof/rtk
that referenced
this pull request
Oct 5, 2026
KuSh, on rtk-ai#2426: "skipping commands that already start with `rtk `". `rtk git status` reaching the hook means the agent already used rtk -- either carried over from an earlier rewrite or typed by the user. Handing it back to `rtk hook opencode` cannot improve it, and it costs a process spawn on every such call. hooks/pi/rtk.ts already does this with a bare `startsWith("rtk ")`. The regex here additionally tolerates leading whitespace, since the shell ignores it and the command may arrive that way.
amnesiaof
added a commit
to amnesiaof/rtk
that referenced
this pull request
Oct 5, 2026
KuSh, on rtk-ai#2426: "honouring RTK_DISABLED". `RTK_DISABLED=1` is the escape hatch hooks/README.md documents for users who want a run without rtk, and hooks/pi/rtk.ts already checks it. Without it the OpenCode plugin was the one TS hook that could not be turned off short of editing the file. Checked per call rather than at setup, for the same reason pi does: the variable is inherited from whatever launched OpenCode, so a user can start a session with it set and get a clean baseline. Only the exact string "1" disables rewriting -- "0" and "true" are not the documented form and must not silently turn the plugin off.
amnesiaof
added a commit
to amnesiaof/rtk
that referenced
this pull request
Oct 5, 2026
…51.1 KuSh's review of rtk-ai#2426 named two gaps that also apply here: the plugin decided usability from the file's existence, and set no minimum version. existsSync only proves a file is there. A wrong-arch binary, a broken install, or a stale RTK_BIN all pass that check and then fail on every single tool call. Spawning `rtk --version` once per session is the check that actually means something, and the answer is cached per binary. The floor is 0.51.1, not 0.51.0: `rtk hook opencode` was added in rtk-ai#4349 and exists in no released version -- v0.51.0's src/main.rs has no HookCommands::Opencode variant. Without the gate a 0.51.0 user gets a plugin that registers hooks, delegates to a missing subcommand, and silently passes every command through. A develop build reports 0.49.0 because release-please only bumps Cargo.toml on master, and the warning it gets is accurate: such a build has no release version. An unparseable banner is not evidence of an old rtk, so it passes and the delegation call still fails open.
amnesiaof
added a commit
to amnesiaof/rtk
that referenced
this pull request
Oct 5, 2026
KuSh, on rtk-ai#2426: "skipping commands that already start with `rtk `". `rtk git status` reaching the hook means the agent already used rtk -- either carried over from an earlier rewrite or typed by the user. Handing it back to `rtk hook opencode` cannot improve it, and it costs a process spawn on every such call. hooks/pi/rtk.ts already does this with a bare `startsWith("rtk ")`. The regex here additionally tolerates leading whitespace, since the shell ignores it and the command may arrive that way.
amnesiaof
added a commit
to amnesiaof/rtk
that referenced
this pull request
Oct 5, 2026
KuSh, on rtk-ai#2426: "honouring RTK_DISABLED". `RTK_DISABLED=1` is the escape hatch hooks/README.md documents for users who want a run without rtk, and hooks/pi/rtk.ts already checks it. Without it the OpenCode plugin was the one TS hook that could not be turned off short of editing the file. Checked per call rather than at setup, for the same reason pi does: the variable is inherited from whatever launched OpenCode, so a user can start a session with it set and get a clean baseline. Only the exact string "1" disables rewriting -- "0" and "true" are not the documented form and must not silently turn the plugin off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the OpenCode and OpenClaw TypeScript plugins with the Pi rewrite contract.
Changes
which rtkwithrtk --version>= 0.23.0)RTK_DISABLED=1rtk0or3execFileSynctospawnSyncso exit code3is handled correctlyWhy
which rtkis a weaker probe here:whichrtksupportsrtk rewritertk --versionchecks the actual binary we want to use and lets us validate compatibility in the same step.Test plan
I wrote and verified some unit tests locally, but left them out to keep things in line with the other TypeScript hooks. Can add them too if that makes sense.
cargo fmt --all && cargo clippy --all-targets && cargo testrtk <command>output inspected