Skip to content

feat: add optional prop in combobox component to show tooltip on truncated options - #355

Merged
saranshsinhaa merged 2 commits into
developfrom
feat/combobox-tooltip-truncated-v2
Sep 11, 2026
Merged

feat: add optional prop in combobox component to show tooltip on truncated options#355
saranshsinhaa merged 2 commits into
developfrom
feat/combobox-tooltip-truncated-v2

Conversation

@saranshsinhaa

@saranshsinhaa saranshsinhaa commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Adds a new optional prop to the Combobox component to show tooltip on hover for options where text is truncated

Screenshot/Screencast

Screen.Recording.2026-09-09.at.7.24.22.PM.mov

Checklist

  • If this PR adds a new component, it has a linked issue that was discussed and approved before I started work.
  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Part of: rtCamp/next-pms#2139

Required for: rtCamp/next-pms#2166

@saranshsinhaa saranshsinhaa self-assigned this Sep 10, 2026
@saranshsinhaa saranshsinhaa mentioned this pull request Sep 10, 2026
Closed
5 tasks
@saranshsinhaa

saranshsinhaa commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

Duplicate for #352

@saranshsinhaa
saranshsinhaa marked this pull request as ready for review September 10, 2026 09:02
@saranshsinhaa saranshsinhaa mentioned this pull request Sep 10, 2026
Closed
5 tasks
@saranshsinhaa
saranshsinhaa force-pushed the feat/combobox-tooltip-truncated-v2 branch from c8b0e4a to 0657d66 Compare September 10, 2026 15:14
@saranshsinhaa

saranshsinhaa commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Changed the commit signing from SSH to GPG, hence the force push

@saranshsinhaa saranshsinhaa mentioned this pull request Sep 10, 2026
Merged
5 tasks
b1ink0
b1ink0 requested changes Sep 11, 2026
View reviewed changes
Comment thread packages/frappe-ui-react/src/components/combobox/combobox.tsx
@saranshsinhaa
saranshsinhaa merged commit d1d67ad into develop Sep 11, 2026
1 check passed
@b1ink0
b1ink0 deleted the feat/combobox-tooltip-truncated-v2 branch September 11, 2026 17:28
@b1ink0 b1ink0 mentioned this pull request Sep 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@b1ink0 b1ink0 b1ink0 approved these changes
@ayushnirwal ayushnirwal Awaiting requested review from ayushnirwal

Assignees

@saranshsinhaa saranshsinhaa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saranshsinhaa @b1ink0