Closed
Conversation
…ignette rmarkdown Agent-Logs-Url: https://github.com/rstudio/reactlog/sessions/8a4f4a4c-8c6f-4dff-9c5d-e0b5c39b5b78 Co-authored-by: karangattu <4220325+karangattu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix automated package checks for reactlog on main
Fix R CMD check failures in depends-only mode
Apr 15, 2026
Contributor
|
Closing this since #98 is more comprehensive fix than this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs caused
R CMD checkto fail under_R_CHECK_DEPENDS_ONLY_=true(where onlyDependsandVignetteBuilderpackages are installed, notSuggests).Changes
R/shinyModule.R— brokentryCatcherror handler:error = function()missing its condition argument causesError in value[[3L]](cond): unused argument (cond)at test runtime. Fixed toerror = function(e).R/shinyModule.R— invalidreturn()in example:shinyis unavailable in depends-only mode; theif (!require("shiny")) { return() }guard callsreturn()at top level, which is illegal inR CMD checkexamples. Replaced withif (require("shiny")) { <entire example> }.DESCRIPTION—rmarkdownmissing fromVignetteBuilder: R CMD check only installsVignetteBuilderpackages for vignette rebuilding in depends-only mode.rmarkdownwas only inSuggests, so vignette rebuild failed withthere is no package called 'rmarkdown'. AddedrmarkdowntoVignetteBuilder.