You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pachadotdev Thank you for this PR (and all the other ones you submitted). In getting that last urgent release out I wasn't able to get this one in for that. But I'm hoping to resolve this one soon. Along with some light modernization work, this PR will be part of the next release. Thanks again!
@pachadotdev Thank you for this PR (and all the other ones you submitted). In getting that last urgent release out I wasn't able to get this one in for that. But I'm hoping to resolve this one soon. Along with some light modernization work, this PR will be part of the next release. Thanks again!
No rush, I have been using PostgreSQL 100% of the time in the last months. This was just a tiny back-contribution as I saw another user had an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the solution is to generalize
is_tbl_mssql()to DuckDB and other backends and detect by class