Add aria-controls to navbar navigation list object - #1355
Merged
Merged
Conversation
added aria-controls to navbar navigation list object
Contributor
Author
|
How would we write a unit test for this? |
Member
Thanks for the PR! Do you think we could extend the tabset ID tests around here to include tests for the |
…t in the rendered HTML for a tabset with an id.
jcheng5
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added aria-controls to navbar navigation list object
Fixes #1354
Pull Request
Before you submit a pull request, please ensure you've completed the following checklist
Ensure there is an already open and relevant GitHub issue describing the problem in detail and you've already received some indication from the maintainers that they are welcome to a contribution to fix the problem. This helps us to prevent wasting anyone's time.
Add unit tests in the tests/testthat directory.
This project uses roxygen2 for documentation. If you've made changes to documentation, run
devtools::document().Run
devtools::check()(or, equivalently, click on Build->Check Package in the RStudio IDE) to make sure your change did not add any messages, warnings, or errors.Ensure your code changes follow the style outlined in http://r-pkgs.had.co.nz/style.html
Add an entry to NEWS.md concisely describing what you changed.