Skip to content

Add aria-controls to navbar navigation list object - #1355

Merged
jcheng5 merged 3 commits into
rstudio:mainfrom
shelbylevel:page-navbar-aria-controls
Sep 17, 2026
Merged

jcheng5 merged 3 commits into
rstudio:mainfrom
shelbylevel:page-navbar-aria-controls

Conversation

@shelbylevel

@shelbylevel shelbylevel commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

added aria-controls to navbar navigation list object
Fixes #1354

Pull Request

Before you submit a pull request, please ensure you've completed the following checklist

  • Ensure there is an already open and relevant GitHub issue describing the problem in detail and you've already received some indication from the maintainers that they are welcome to a contribution to fix the problem. This helps us to prevent wasting anyone's time.

  • Add unit tests in the tests/testthat directory.

  • This project uses roxygen2 for documentation. If you've made changes to documentation, run devtools::document().

  • Run devtools::check() (or, equivalently, click on Build->Check Package in the RStudio IDE) to make sure your change did not add any messages, warnings, or errors.

    • Note there is a decent chance that some tests were already failing before your changes. Just make sure you haven't introduced any new ones.
  • Ensure your code changes follow the style outlined in http://r-pkgs.had.co.nz/style.html

  • Add an entry to NEWS.md concisely describing what you changed.

added aria-controls to navbar navigation list object
@CLAassistant

CLAassistant commented Sep 17, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@shelbylevel

Copy link
Copy Markdown
Contributor Author

How would we write a unit test for this?

@gadenbuie

Copy link
Copy Markdown
Member

How would we write a unit test for this?

Thanks for the PR! Do you think we could extend the tabset ID tests around here to include tests for the aria-controls attribute?

…t in the rendered HTML for a tabset with an id.
@jcheng5
jcheng5 merged commit e3b7616 into rstudio:main Sep 17, 2026
11 of 12 checks passed
@shelbylevel
shelbylevel deleted the page-navbar-aria-controls branch September 17, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

page_navbar() tab controls are missing aria-controls attributes

4 participants