fix: keep Prettier and Biome away from skills-lock.json - #180
Conversation
Skills are installed into .agents with their hash recorded in skills-lock.json, but neither was ignored, so formatting a new project rewrote third-party skill files. Ignore both in the Prettier and Biome templates.
chenjiahan
left a comment
chenjiahan
left a comment
There was a problem hiding this comment.
Ignoring all of .agents seems too broad: it can also contain project-maintained skills that should follow the project's formatting rules. The template cannot reliably distinguish those from installed third-party skills.
Could we keep the skills-lock.json exclusion and leave skill directory exclusions to individual projects for now?
.agents can also hold skills a project maintains itself, which should follow its formatting rules, so leave excluding skill directories to each project.
upupming
changed the title
|
Makes sense. Now only |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
skills-lock.jsonis written by the skills CLI, but the Prettier and Biome templates did not ignore it, so formatting a new project could rewrite it. Ignore it in both. Skill directories under.agentsare left to each project, since they may also hold skills the project maintains.