fix: head-skipping dropping matches in rare circumstances#972
Merged
Conversation
Head-skipping would incorrectly start from the start of a block if quote classification dropped it at the final structural character. In rare cases where a quote in that block aligned with the start of a match in the next block it would cause the engine to miss matching results. The fix is to manually check if the block is still valid, i.e. idx != BLOCK_SIZE before continuing memmem. Resolves: #971
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Head-skipping would incorrectly start from the start of a block if quote classification dropped it at the final structural character. In rare cases where a quote in that block aligned with the start of a match in the next block it would cause the engine to miss matching results.
The fix is to manually check if the block is still valid, i.e. idx != BLOCK_SIZE before continuing memmem.
Issue
Resolves: #971
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.