task.c: make recode_get_bytes read from the input buffer - #76
Merged
rrthomas merged 1 commit intoSep 23, 2026
Conversation
When the input is a memory buffer, recode_get_bytes copied bytes from the subtask's *output* buffer, and advanced the output cursor, instead of reading the input text. With an empty output it returned no data at all; otherwise it returned (and consumed) output bytes. recode(1) only calls it for file input, but it is declared in recodext.h for externally written steps. Read from the input buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the input is a memory buffer, recode_get_bytes copied bytes from the subtask's output buffer, and advanced the output cursor, instead of reading the input text. With an empty output it returned no data at all; otherwise it returned (and consumed) output bytes.
recode(1) only calls it for file input, but it is declared in recodext.h for externally written steps. Read from the input buffer.