Conversation
When no table name was given, recode_format_table used the string returned by recode_edit_sequence as the table name, modified it in place, and freed it. That string is the request's own work_string, which recode_delete_request frees again later: request = recode_new_request (outer); request->make_header_flag = true; recode_scan_request (request, "latin1..ibmpc"); recode_format_table (request, RECODE_LANGUAGE_C, NULL); recode_delete_request (request); /* double free */ Always work on a copy of the name.
Owner
|
Many thanks for this and your other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no table name was given, recode_format_table used the string returned by recode_edit_sequence as the table name, modified it in place, and freed it. That string is the request's own work_string, which recode_delete_request frees again later:
request = recode_new_request (outer);
request->make_header_flag = true;
recode_scan_request (request, "latin1..ibmpc");
recode_format_table (request, RECODE_LANGUAGE_C, NULL);
recode_delete_request (request); /* double free */
Always work on a copy of the name.