Skip to content

Add support for []-methods in Magik - #2318

Merged
jneen merged 2 commits into
rouge-ruby:mainfrom
sebastiaanspeck:patch-1
Aug 26, 2026
Merged

jneen merged 2 commits into
rouge-ruby:mainfrom
sebastiaanspeck:patch-1

Conversation

@sebastiaanspeck

Copy link
Copy Markdown
Contributor

No description provided.

@jneen

jneen commented Jul 23, 2026

Copy link
Copy Markdown
Member

Thanks for the contribution! Would you mind adding an example to spec/visual/samples/magik that uses this feature?

@sebastiaanspeck

Copy link
Copy Markdown
Contributor Author

Thanks for the contribution! Would you mind adding an example to spec/visual/samples/magik that uses this feature?

Done! Anything more needed?

Comment thread lib/rouge/lexers/magik.rb Outdated
Comment thread lib/rouge/lexers/magik.rb Outdated
Comment thread lib/rouge/lexers/magik.rb Outdated
@jneen

jneen commented Aug 26, 2026

Copy link
Copy Markdown
Member

Aaaand I just realized that in the haze of the morning I missed that this is an edit to the lexer and not a new lexer. With that context I think it's fine to merge.

@sebastiaanspeck

Copy link
Copy Markdown
Contributor Author

Aaaand I just realized that in the haze of the morning I missed that this is an edit to the lexer and not a new lexer. With that context I think it's fine to merge.

Great to hear! If you want, I can open a new PR (after this one) that addresses your comments.

@jneen
jneen added this pull request to the merge queue Aug 26, 2026
Merged via the queue into rouge-ruby:main with commit f4e6f59 Aug 26, 2026
@sebastiaanspeck
sebastiaanspeck deleted the patch-1 branch August 26, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants