Skip to content

Harden and pin GitHub Actions - #283

Merged
kelsos merged 1 commit into
rotki:mainfrom
kelsos:harden-actions
Jul 3, 2026
Merged

Harden and pin GitHub Actions#283
kelsos merged 1 commit into
rotki:mainfrom
kelsos:harden-actions

Conversation

@kelsos

@kelsos kelsos commented Jul 3, 2026

Copy link
Copy Markdown
Member

Summary

Hardens the verify workflow following GitHub Actions security best practices. Passes zizmor with no findings.

Changes

  • Pin all actions to full commit SHAs (with version comments):
    • actions/checkout → v7.0.0
    • actions/setup-python → v6.3.0
    • actions/cache → v6.1.0
  • Set persist-credentials: false on checkout so the GITHUB_TOKEN is not left in the local git config.
  • Restrict the GITHUB_TOKEN: top-level permissions: {} (deny all) with contents: read granted only to the job.
  • Add timeout-minutes: 15 to bound runaway jobs (recent runs finish in ~2 min).

Verification

  • zizmor .github/workflows/verify.yml → no findings.

- Pin all actions to full commit SHAs (checkout v7, setup-python v6.3, cache v6.1)
- Set persist-credentials: false on checkout
- Restrict GITHUB_TOKEN with top-level permissions: {} and contents: read on the job
- Add timeout-minutes to bound runaway jobs

Passes zizmor with no findings.
@kelsos
kelsos merged commit 481adcb into rotki:main Jul 3, 2026
2 checks passed
@kelsos
kelsos deleted the harden-actions branch July 3, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant