Skip to content

Add emscripten guards to shared_library.c's dlopen path #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 3 commits into from
Sep 15, 2026
+14 −2
Merged

Add emscripten guards to shared_library.c's dlopen path #591

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2da7412
fix: add emscripten guards to shared_library.c's dlopen path
Tobias-Fischer Sep 9, 2026
a8f5711
make linters happy
ahcorde Sep 14, 2026
55750a6
make linters happy
ahcorde Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/shared_library.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,14 @@ rcutils_load_shared_library(
goto fail;
}
lib->library_path = rcutils_strdup(image_name, lib->allocator);
#elif defined(_GNU_SOURCE) && !defined(__QNXNTO__) && !defined(__ANDROID__) && !defined(__OHOS__)
// Emscripten defines _GNU_SOURCE but its dlopen()/dlinfo() are a JS-backed
// shim, not glibc's -- RTLD_DI_LINKMAP support (reading back a real
// struct link_map) doesn't exist there. A successful dlopen() would
// otherwise get treated as a failure once dlinfo() returns -1 below; the
// #else branch already covers this correctly (it just reuses the path we
// opened the library from, no introspection needed).
#elif defined(_GNU_SOURCE) && !defined(__QNXNTO__) && !defined(__ANDROID__) && \
!defined(__OHOS__) && !defined(__EMSCRIPTEN__)
struct link_map * map = NULL;
if (dlinfo(lib->lib_pointer, RTLD_DI_LINKMAP, &map) != 0) {
RCUTILS_SET_ERROR_MSG_WITH_FORMAT_STRING("dlinfo error: %s", dlerror());
Expand Down Expand Up @@ -291,7 +298,12 @@ rcutils_get_platform_library_name(

int written = 0;

#if defined(__linux__) || defined(__QNXNTO__)
// rcl_logging_implementation dlopens its backend (spdlog or noop) by name
// at runtime via this function -- with no emscripten case it always falls
// through with written == 0 ("failed to format library name"), regardless
// of which backend RCL_LOGGING_IMPLEMENTATION selects. wasm32 side modules
// use the same "lib<name>.so" naming convention as Linux.
#if defined(__linux__) || defined(__QNXNTO__) || defined(__EMSCRIPTEN__)
if (debug) {
if (buffer_size >= (strlen(library_name) + 8)) {
written = rcutils_snprintf(
Expand Down