Repository navigation
feat: show error dialog when server actions fail - #57
Merged
Merged
Conversation
Server actions previously failed silently. Now all actions return
{ error } on failure, surfaced via a native <dialog> modal matching
the existing SiteFormDialog style.
Closes #56
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Updates to Preview Branch (feature/sms-alerting) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…eturn Bare `return` on validation failures (missing fields, invalid webhook URL) caused silent failures with no error dialog. Now all early returns surface a user-facing message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The fetch response body was never read, causing the browser to log "Fetch failed loading" on every Slack notification. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The mock responses were missing .text(), causing "response.text is not a function" after we started consuming the Slack webhook response body. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasoncrawford
enabled auto-merge
February 24, 2026 14:30
The DB insert succeeds but the Resend call throws (e.g., no API key in CI). We were returning early with an error, skipping revalidatePath, so the new invitation never appeared on the page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ErrorDialogProvidercontext with a native<dialog>modal (styled to matchSiteFormDialog) and auseErrorDialog()hookaddSite,editSite,deleteSite,reorderSites,resolveIncident,addContact,deleteContact,sendInvitation,revokeInvitation) now return{ error: string }on failure instead of silently swallowing errorsSiteFormDialog,AddContactForm,SiteList) check return values and show the error dialog; only perform success side-effects (close dialog, reset form) when there's no errorActionFormclient wrapper for server-component pages (SettingsPage,IncidentDetailPage) that can't use hooks directlyCloses #56
Test plan
🤖 Generated with Claude Code