Repository navigation
Replace inline site edit with dialog popover - #32
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Simplify AddSiteCard to just a trigger for the dialog - Status page pencil icon opens dialog instead of inline edit - Site detail page uses full Edit button opening dialog - Delete EditSiteButton.tsx (replaced by SiteFormDialog) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Dialog selectors instead of inline form selectors - Test Escape key dismissal - Test delete confirmation flow (Delete → Yes) - Site detail uses Edit button instead of pencil icon Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- useId() for label/input associations to avoid id collisions
- Use getByRole('button', { name: 'Add site' }) to avoid ambiguity
with dialog title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
When I try to view the deployment, I get: |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
The popover is flush with the upper left corner of the view. Can it be centered in the view? Also the Edit button on the site detail page is very low-contrast, easy to miss. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…Button Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasoncrawford
enabled auto-merge
February 21, 2026 05:39
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SiteFormDialogcomponent using native<dialog>for both add and edit flowsEditSiteButtoncomponent entirely, simplifiedAddSiteCardCloses #31
Test plan
🤖 Generated with Claude Code