Repository navigation
Fix site edit button visibility and overlay - #30
Merged
Merged
Conversation
The edit button was invisible on the site detail page because it had opacity-0 with group-hover but no group ancestor. On the main page, the edit form overlay was broken because it was nested inside an absolutely positioned wrapper, making its inset-0 relative to the wrapper instead of the card. Add overlay prop to EditSiteButton: when true (card context), the button positions itself absolutely with hover visibility and the form overlays the card; when false (detail page), both are inline and always visible. Fixes #28, fixes #29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jasoncrawford
enabled auto-merge
February 20, 2026 16:03
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opacity-0 group-hover:opacity-100but the site detail page had nogroupancestor, so it was permanently invisibleabsolute inset-0but was nested inside a<div className="absolute top-3 right-3">wrapper, which became its containing block instead of the card — producing mispositioned overlapping rectanglesBoth fixed by adding an
overlayprop toEditSiteButton. Whenoverlayis true (main page cards), the component self-positions absolutely and the form fills the card. When false (detail page), both button and form render inline and are always visible.Test plan
Fixes #28, fixes #29
🤖 Generated with Claude Code