Skip to content

CI: Modernize go commands #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swalkinshaw merged 1 commit into from
Oct 8, 2026
Merged

CI: Modernize go commands #740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,16 @@ jobs:
version: latest
args: --timeout=5m

go-modernize:
name: Modernize
go-fix:
name: Go Fix
runs-on: ubuntu-latest
timeout-minutes: 5
steps:
- uses: actions/checkout@v7
- uses: actions/setup-go@v6
with:
go-version-file: 'go.mod'
cache: true
- name: Check modernized code
run: |
go run golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest -fix ./...
if ! git diff --exit-code; then
echo "Code is not modernized. Run the following locally and commit the changes:"
echo " go run golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest -fix ./..."
exit 1
fi
- name: Check for suspicious constructs or opportunities for improvement
run: go fix -diff ./...

go-mod-tidy:
name: Go Modules Tidy
Expand All @@ -66,14 +58,8 @@ jobs:
- uses: actions/setup-go@v6
with:
go-version-file: 'go.mod'
- name: Check if go.mod is tidy
run: |
go mod tidy
if [ -n "$(git diff --name-only)" ]; then
echo "go.mod is not tidy. Please run 'go mod tidy'"
git diff
exit 1
fi
- name: Check if go.mod/go.sum are tidy
run: go mod tidy -diff

test:
runs-on: ubuntu-latest
Expand Down
Loading