perf(data-plane): avoid local batch copies - #7
Open
rohitrango wants to merge 5 commits into
Open
rohitrango wants to merge 5 commits into
rohitrango wants to merge 5 commits into
Conversation
Signed-off-by: rohitrango <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohit.rango@gmail.com>
Signed-off-by: rohitrango <rohit.rango@gmail.com>
rohitrango
force-pushed
the
rohit/packedtensor_opt
branch
2 times, most recently
from
September 11, 2026 00:47
0bff7dc to
a609bff
Compare
rohitrango
added this pull request to stack #9
September 11, 2026 03:21
Keep one-field-at-a-time staging while moving PackedTensor segments to the NCCL device before concatenation. This avoids the large CPU concatenation and subsequent flat host-to-device copy in worker fetch. Signed-off-by: Rohit Jena <rohit.rango@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Avoids unnecessary copies when fetching full or subset batches from the local data plane. It also preserves PackedTensor physical-segment deduplication across replica broadcasts so shared media is transferred once instead of being expanded per logical row.
Adds coverage that verifies full local fetches share tensor storage and replica broadcasts preserve PackedTensor row mappings, provenance, preprocessing configuration, and physical tensors.
This PR is stacked on NVIDIA-NeMo#4082 via `rohit/packedtensor_padding`.
Issues
None.
Usage
No user-facing API changes.
Before your PR is "Ready for review"
Pre checks:
Additional Information
Validated on Slurm job `18295320` (`pool0-01445`):
```text
uv run --frozen --group test pytest --confcutdir=tests/unit/data_plane -q tests/unit/data_plane/test_leader_broadcast.py
```
Result: 5 passed. Ruff passed for all three changed files, and Pyrefly reported zero errors for both implementation files.