fix(pi): scope memory_save memories to the current project - #1185
fix(pi): scope memory_save memories to the current project#1185hejiawow wants to merge 1 commit into
Conversation
The server's mem::remember only stamps a memory with a project when project is passed explicitly; otherwise the memory is stored as global (project: null). Every other official integration passes its project, so pi was the odd one out: all memories saved from pi landed in the global bucket while observations from the same session were project-scoped. Pass currentProject so memory_save results are queryable under the same project bucket as the session's observations. Search stays global either way (smart-search is not project-filtered), so cross-project recall is unaffected. Signed-off-by: hejia <hejia@ahu.com> Signed-off-by: hejiawow <16770133+hejiawow@users.noreply.github.com>
|
@hejiawow is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesMemory save project scope
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This localized change scopes pi-saved memories to the current project without changing global search behavior; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The server's mem::remember only stamps a memory with a project when project is passed explicitly; otherwise the memory is stored as global (project: null). Every other official integration passes its project, so pi was the odd one out: all memories saved from pi landed in the global bucket while observations from the same session were project-scoped.
Pass currentProject so memory_save results are queryable under the same project bucket as the session's observations. Search stays global either way (smart-search is not project-filtered), so cross-project recall is unaffected.
Summary by CodeRabbit