Skip to content

WIP: Fix edge case for #9 - #10

Open
joyarzun wants to merge 1 commit into
masterfrom
edge-case-9
Open

WIP: Fix edge case for #9#10
joyarzun wants to merge 1 commit into
masterfrom
edge-case-9

Conversation

@joyarzun

@joyarzun joyarzun commented Dec 5, 2016

Copy link
Copy Markdown
Collaborator

This will resolve #9

@pamo

pamo commented Dec 5, 2016

Copy link
Copy Markdown
Collaborator

Came to say this but then I noticed WIP.

  20 passing (42ms)
  1 failing

  1) parser different AMD patterns parses anonymous modules with star:
     AssertionError: expected '\n  define([\'dep1\', \'example\', // requirejs_plugin|*| \'dep2\'], function (dep1, dep2) {\n      return function () {};\n  });\n' to match /example', \/\/ requirejs_plugin\|args\|/
      at Context.it (test/parser.spec.js:65:73)

@joyarzun

joyarzun commented Dec 6, 2016

Copy link
Copy Markdown
Collaborator Author

Yep, It's just a test. If broken the CI then we are happy :p
Broken driven development ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge case for define format

2 participants