Skip to content

feat: Add config-manager push variables - #667

Open
dallinjsevy wants to merge 3 commits into
rockcarver:mainfrom
trivir:feature/config-manager-push-variables
Open

feat: Add config-manager push variables#667
dallinjsevy wants to merge 3 commits into
rockcarver:mainfrom
trivir:feature/config-manager-push-variables

Conversation

@dallinjsevy

@dallinjsevy dallinjsevy commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

I added functions to ConfigManagerVariablesOps and CLI implementation for the config-manager push variables command.

I also added support for ESV placeholders in Config Manager, including global environment flags and updated conflicting flags.

This PR is dependent on the changes made to Frodo-lib in the feature/add-replaceEnvSpecifiValues PR.

@vscheuber
vscheuber force-pushed the feature/config-manager-push-variables branch from d15e7b2 to dff7e7b Compare August 18, 2026 21:52
@vscheuber

Copy link
Copy Markdown
Contributor

@phalestrivir @dallinjsevy We have the same issue with the package version here, which I am getting to the bottom of. I believe it is caused by the new version-bump action I created to replace the marketplace one. I think I understand that part and will fix it.

However, when I run the test locally, I still get failures. Could you guys maybe run the tests with frodo-lib 4.4.0 and see if you get the same?

@phalestrivir

Copy link
Copy Markdown
Contributor

@vscheuber @dallinjsevy I believe I fixed it (I pushed a fixup commit with the snapshot update I made). The tests are passing for me now locally.

@vscheuber

Copy link
Copy Markdown
Contributor

@phalestrivir @dallinjsevy fantastic! I fixed the action to not base the new version on the source repo tags if the source repo is a fork but fallback to package.json. So that should fix the "there's a new version available" snapshot pollution. Tests are running now. If they all pass, I'll merge tonight and publish a new minor release.

@vscheuber

Copy link
Copy Markdown
Contributor

@phalestrivir @dallinjsevy it looks like the same test suite is failing now in the pipeline as is failing for me when I run the tests locally:
FAIL test/e2e/idm-import.e2e.test.js

So the good news is the version issue is addressed but some tests are still failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants