test: re-record CLI-output snapshots for --username help text and resolved-identity Modifier row - #666
Merged
Merged
Conversation
…olved-identity Modifier row Both are real, intentional output changes already published in @rockcarver/frodo-lib 4.3.2 (frodo-lib#628 / frodo-cli#665): the global --username option's help text now documents password auto-resolution from a stored connection profile, and `esv variable describe` now prints a resolved-identity Modifier row alongside the existing Modifier UUID. The frozen snapshots had simply not caught up. These were surfaced while chasing down the systemic e2e breakage fixed by frodo-lib#629 (an unrelated eager IDM-version probe on every login was breaking nearly every Polly-replayed e2e fixture and masking these two diffs underneath it).
Picks up frodo-lib#629, which stops the eager IDM-version probe on every login that was breaking nearly every e2e test's Polly-replayed fixtures. Verified against the published package: full e2e suite is green except 4 pre-existing, unrelated conn-describe.e2e.test.js failures (local connection-profile decryption issue, present before any of this work).
vscheuber
marked this pull request as ready for review
August 18, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While investigating the e2e suite failing wholesale (377 of 538 suites), root-caused to rockcarver/frodo-lib#629 (an eager, unnecessary IDM-version probe added on every login that broke nearly every Polly-replayed e2e fixture), two genuine and already-published output changes were hiding underneath that noise and needed their frozen snapshots refreshed:
--usernameoption's--helptext now documents password auto-resolution from a stored connection profile (frodo-lib#628 / frodo-cli#665), which touches nearly every command's help output.esv variable describenow prints a resolved-identityModifierrow alongside the existingModifier UUID(same identity-resolution work).Both changes were already in the published
@rockcarver/frodo-lib@4.3.2this repo depended on when this PR was opened — the snapshots simply hadn't caught up.Now also bumps
@rockcarver/frodo-libto4.3.3, which includes #629's fix.Depends on
Resolved: rockcarver/frodo-lib#629 merged and published as
4.3.3.Test plan
conn-describe.e2e.test.jsfailures (local connection-profile decryption issue, present before any of this work)@rockcarver/frodo-libbumped in package.json (4.3.3)@rockcarver/frodo-lib@4.3.3(not a local link): green except the same 4 pre-existingconn-describe.e2e.test.jsfailures